Makes use of newer feature which produces failures only when current
commit is adding new violations, exiting ones being considered
as already known.
To prove it works, it also removes the E208 from warn, making it
an error. Still, the final linting result is a success because
these violations were already present before current commit.
Change-Id: Ia858f2a3e71d9634e9d90e890d82714105e8f8c9
The apt_key module currently requires that gnupg is in place
in order to be able to succesfully import keys. It is possible
that the system running this role does not have this, so we
should make sure it is installed if we have any keys to install.
Change-Id: Ia5ff4d35dc4faed1fb8dfc6bd32670dae394e5c7
Docker just released official packages for centos-8 so
we need to remove the temporary workaround that installs the
previous release version.
Change-Id: I787ce82b895069f4846fcdb35f55f0c9ad53652c
Extend bindep role to be able to install packages from
multiple paths at once. This behavior is fully compatible
with current implementation, however it allows to pass
number of bindep file paths.
Change-Id: I70d42f25837ff282aad534f9ead965d12858ac9b
Instead of getting a confusing stacktrace when someone adds a new
file that is missing the final project entry we now give a friendlier
error that also recommends way to address the issue.
Change-Id: I5a84d3a20e847eeb2d5d843ef970b5790532683c
The merge-output-to-logs role is not doing anything in this test. As
described inline, this merges files in
zuul.executor.work_root/<docs,artifacts> into the
zuul.executor.log_root directory so they are available in change
results.
Since this job doesn't publish anything there, this role is unused.
merge-output-to-logs currently can't run because it tries to run shell
scripts on the executor. Thus we can remove this unused role and
restore the job.
Change-Id: I1afc905aa8d9c420bed316e99760ad7ad1d838ce
This reverts commit 51a8ed8e95a2240547b0128701cc8acf6ba8bbcc.
This has a typo ("exector"). The fix is obvious, but the bigger
issue is that it was not caught in testing, even though the main
purpose of the change was to re-enable tests. We should understand
why it wasn't caught in testing and resolve that before fixing and
unreverting.
Change-Id: I3ed407546fecc52d4a039f7959c0521511e6a00b
In case of nodeset which doesn't have peers and switch there is
no need to install openswitch and firewall rules, because nothing
will be installed. Let's skip it if no need.
Change-Id: I98cf5ec390ee22e538baa076c9ab87eea6a44c9e
The openstacksdk dropped py35 support in 0.48.0. Since we still have
py35 support we need to pin it temporarily until we've deprecated and
removed it.
Change-Id: Ia50ed54f43605fc1e12c95a2218b73abcadc66ed
As described inline, we should lower the MTU in the docker
configuration when we see the interface has a MTU lower than 1500 so
things "just work". This particularly affects the Linaro ARM64 cloud
in OpenDev, but it is a generic issue.
Change-Id: I338616c41a65b007d56648fdab6da2a6a6b909f4
Story: https://storyboard.openstack.org/#!/story/2008230
Verifies that installed docker can download and run containers
that need network access. This should prevent bugs where
service was installed but in a broken state.
Fixes bug which failed to run tests when tests were modified.
Change-Id: I309168719fd3cb7488bc2d0f4fec7785e1eb5d53
Story: https://storyboard.openstack.org/#!/story/2008215
Ansible doens't really have a great built-in way to modify a json file
(unlike ini files). The extant docker role does what seems to be the
usual standard, which is slurp in the file, parse it and then write it
back out.
In a follow-on change (I338616c41a65b007d56648fdab6da2a6a6b909f4) we
need to set some more values in the docker configuration .json file,
which made me think it's generic enough that we can have a role to
basically run read the file, |combine and write it back out.
This adds such a role with various options, and converts the existing
json configuration update in ensure-docker to use it.
Change-Id: I155a409945e0175249cf2dc630b839c7a97fb452
This reverts commit 69a238df46ca81e8890ebb2ace7addcbb4852911.
The role is re-written with executor-safe methods.
Depends-On: https://review.opendev.org/753222
Change-Id: I0b52eff66bfdca776e0e5c426bf1fc57deb3fc49
All log upload modules use a large portion of common code for finding
files and creating indexes. Move this into module_utils so this can be
shared between all.
Change-Id: I16c105bc70e07b0c8a4aa8e96119ab7451e00346
This dependency was added with
Iaf4da5aedaa3814b2ecebed4391da2324d3e388d to prevent a warning when
using "twine check" with text/markdown descriptions.
Per [1], this check doesn't really do anything and will never fail.
We are now having issues using this role with with Python 3.8 on the
executor as the md dependency pulls in cmarkgfm which has binary
dependencies but does not publish any wheels; meaning the executor
fails to install as it does not have a toolchain setup. Unfortunately
upstream is not particularly active, so building good manylinux wheels
is not something we're going to be able to deal with in a timely
fashion.
Given that this is not a failure, and isn't really doing anything and
blocks Python 3.8, it seems our best course is to remove this
dependency.
[1] https://github.com/pypa/twine/pull/421
Change-Id: Iac5c9f63d41375889e4fdad67b9a45a24a644341
Use buildset_registry_alias for certificate file name to address
'unknown certificate authority' issue on consumer side when using standalone
use-buildset-registry role.
Issue is not visible with opendev parent jobs because certificate is handled
in pull-from-intermediate-registry role there.
Change-Id: Ieaf43be0dd4ccb92a8240a493ee6636a23c9d484
Signed-off-by: Andrii Ostapenko <andrii.ostapenko@att.com>
- replaces ignore with a warn, which displays issue without affecting
the linting outcome (allowing gradual fixing)
- bumps linter to enable the warn_list feature
- fixes a set of issues, others will be fixed in follow-up
Change-Id: I7d6f8c156b06f68f681943e88860930968e7c9f9
map returns a generator that needs to be converted to a list for
the loop.
We also don't need unique as this is iterating over a list of
directory names that must already be unique.
Change-Id: Ibd22d79be29aaa9d3a7924319c59929e665f9cbc
