Revert "Use --password-stdin for upload-container-image"

This reverts commit 345c839db64f6ee1566fda07b6a706ee8ff7f0d9.

This is simpler, and we don't have to worry about the tempfile write
accidentally exposing secrets.  This is similar to the way we log in
in the promote job.

Change-Id: I2a0f34e0ea3abe88fe9f26d12298baf68f1a6b2d

roles/upload-container-image/tasks/push.yaml

@@ -1,22 +1,6 @@
-- name: Create tempfile for password
-  tempfile:
-    state: file
-  register: _password_tmp
-
-- name: Populate tempfile
-  copy:
-    content: "{{ container_registry_credentials[zj_image.registry].password }}"
-    dest: "{{ _password_tmp.path }}"
-    mode: 0600
-
 - name: Log in to registry
-  block:
+  command: "{{ container_command }} login -u {{ container_registry_credentials[zj_image.registry].username }} -p {{ container_registry_credentials[zj_image.registry].password }} {{ zj_image.registry }}"
-    - name: Log in to registry
+  no_log: true
-      shell: "cat {{ _password_tmp.path }} | {{ container_command }} login -u {{ container_registry_credentials[zj_image.registry].username }} --password-stdin {{ zj_image.registry }}"
-
-  always:
-    - name: Remove password from disk
-      command: "shred {{ _password_tmp.path }}"
 
 - name: Publish images
   block: