x/vmware-nsxlib
Code Issues Proposed changes

Avoid logging sensitive information in http header

Browse Source 
Change-Id: Ic30b8075cd46632ea68f04c15028b804f63b3947
This commit is contained in:
Anna Khmelnitsky 2020-02-12 13:01:55 -08:00
parent 03fd42824e
commit ae9d18cb8a
3 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
vmware_nsxlib/v3/client.py
View File

@ -224,7 +224,8 @@ class RESTClient(object):
if not silent: if not silent:
LOG.debug("REST call: %s %s. Headers: %s. Body: %s", LOG.debug("REST call: %s %s. Headers: %s. Body: %s",
method, request_url, request_headers, method, request_url,
utils.censor_headers(request_headers),
self._mask_password(body)) self._mask_password(body))
ts = time.time() ts = time.time()

4
vmware_nsxlib/v3/cluster.py
View File

@ -323,7 +323,9 @@ class NSXRequestsHTTPProvider(AbstractHTTPProvider):
resp.headers[header_name]) resp.headers[header_name])
LOG.info("Session create succeeded for endpoint %(url)s with " LOG.info("Session create succeeded for endpoint %(url)s with "
"headers %(hdr)s", "headers %(hdr)s",
{'url': provider.url, 'hdr': session.default_headers}) {'url': provider.url,
'hdr':
utils.censor_headers(session.default_headers)})
class NSXHTTPAdapter(adapters.HTTPAdapter): class NSXHTTPAdapter(adapters.HTTPAdapter):

12
vmware_nsxlib/v3/utils.py
View File

@ -62,6 +62,18 @@ def set_inject_headers_callback(callback):
INJECT_HEADERS_CALLBACK = callback INJECT_HEADERS_CALLBACK = callback
def censor_headers(headers):
censored_headers = ['authorization']
result = {}
for name, value in headers.items():
if name.lower() in censored_headers:
result[name] = '--- CENSORED ---'
else:
result[name] = value
return result
def _update_resource_length(length): def _update_resource_length(length):
global MAX_RESOURCE_TYPE_LEN global MAX_RESOURCE_TYPE_LEN
MAX_RESOURCE_TYPE_LEN = length MAX_RESOURCE_TYPE_LEN = length