
This patch set enables PEP8 standard check for project Valet, and corrects all outstanding PEP8 issues. Story: #2001040 Task: #4602 Co-Authored-By: Omar Rivera <gomarivera@gmail.com> Change-Id: I4b987ff28b02ea8a6da77fb0f29eda1515d212ac
120 lines
4.8 KiB
Python
120 lines
4.8 KiB
Python
#
|
|
# Copyright 2014-2017 AT&T Intellectual Property
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
import mock
|
|
|
|
from valet.api.db.models.music.plans import Plan
|
|
from valet.api.db.models.music import Query
|
|
from valet.api.db.models.music import Results
|
|
import valet.api.v1.controllers.plans as plans
|
|
from valet.api.v1.controllers.plans import PlansController
|
|
from valet.api.v1.controllers.plans import PlansItemController
|
|
from valet.tests.unit.api.v1.api_base import ApiBase
|
|
|
|
|
|
class TestPlans(ApiBase):
|
|
"""Unit tests for valet.api.v1.controllers.plans."""
|
|
|
|
def setUp(self):
|
|
"""Setup TestPlans, set PlansController, init PlansItemController."""
|
|
super(TestPlans, self).setUp()
|
|
|
|
self.plans_controller = PlansController()
|
|
self.plans_item_controller = self.init_PlansItemController()
|
|
|
|
@mock.patch.object(plans, 'error', ApiBase.mock_error)
|
|
@mock.patch.object(Query, 'filter_by')
|
|
@mock.patch.object(plans, 'request')
|
|
def init_PlansItemController(self, mock_request, mock_filter):
|
|
"""Called by setup, return PlansItemController with uuid4."""
|
|
mock_request.context = {}
|
|
mock_filter.return_value = Results(["", "second"])
|
|
try:
|
|
PlansItemController("uuid4")
|
|
except Exception as e:
|
|
self.validate_test("'str' object has no attribute 'id'" in e)
|
|
self.validate_test("Plan not found" in ApiBase.response)
|
|
|
|
mock_filter.return_value = Results([Plan("test_name",
|
|
"stack_id",
|
|
_insert=False)])
|
|
|
|
return PlansItemController("uuid4")
|
|
|
|
def test_allow(self):
|
|
"""Test plans_controller and plans_item_controller allow methods."""
|
|
self.validate_test(self.plans_controller.allow() == 'GET,POST')
|
|
|
|
self.validate_test(
|
|
self.plans_item_controller.allow() == 'GET,PUT,DELETE')
|
|
|
|
@mock.patch.object(plans, 'error', ApiBase.mock_error)
|
|
@mock.patch.object(plans, 'request')
|
|
def test_index(self, mock_request):
|
|
"""Test plans and plans_item_controller index method failure."""
|
|
mock_request.method = "PUT"
|
|
self.plans_controller.index()
|
|
self.validate_test(
|
|
"The PUT method is not allowed" in ApiBase.response)
|
|
|
|
mock_request.method = "POST"
|
|
self.plans_item_controller.index()
|
|
self.validate_test(
|
|
"The POST method is not allowed" in ApiBase.response)
|
|
|
|
def test_index_options(self):
|
|
"""Test index_options method for plans and plans_item_controller."""
|
|
self.plans_controller.index_options()
|
|
self.validate_test(plans.response.status == 204)
|
|
|
|
self.plans_item_controller.index_options()
|
|
self.validate_test(plans.response.status == 204)
|
|
|
|
@mock.patch.object(Query, 'all')
|
|
def test_index_get(self, mock_all):
|
|
"""Test index_get method for plans and plans_item_controller."""
|
|
all_groups = ["group1", "group2", "group3"]
|
|
mock_all.return_value = all_groups
|
|
response = self.plans_controller.index_get()
|
|
|
|
self.validate_test(len(response) == 1)
|
|
self.validate_test(len(response["plans"]) == len(all_groups))
|
|
self.validate_test(all_groups == response["plans"])
|
|
|
|
response = self.plans_item_controller.index_get()
|
|
|
|
self.validate_test(len(response) == 1)
|
|
self.validate_test(response["plan"].name == "test_name")
|
|
|
|
@mock.patch.object(plans, 'error', ApiBase.mock_error)
|
|
def test_index_post(self):
|
|
"""Test plans_controller index_post."""
|
|
with mock.patch('valet.api.v1.controllers.plans.Ostro'):
|
|
self.plans_controller.index_post()
|
|
self.validate_test("Ostro error:" in ApiBase.response)
|
|
|
|
@mock.patch.object(plans, 'error', ApiBase.mock_error)
|
|
@mock.patch.object(Query, 'filter_by', mock.MagicMock)
|
|
def test_index_put(self):
|
|
"""Test plans_item_controller index_put method."""
|
|
kwargs = {'action': "migrate",
|
|
'excluded_hosts': [],
|
|
"resources": ["ggg", "fff"]}
|
|
|
|
with mock.patch('valet.api.v1.controllers.plans.Ostro'):
|
|
self.plans_item_controller.index_put(**kwargs)
|
|
self.validate_test("Ostro error:" in ApiBase.response)
|
|
|
|
# TODO(UNKNOWN): test_index_post, test_index_put needs to be written again
|