x/valence
Code Issues Proposed changes

[API] Nodes get KeyError: 'Members'

Browse Source 
Closes-Bug: #1634381

Change-Id: Ie363dc77ffe2bb6d750e4b419439b32b7a236182
Signed-off-by: Andy Yan <yanchao3@lenovo.com>
This commit is contained in:
Andy Yan 2016-10-18 15:26:56 +08:00
parent 44b034953b
commit bb37d76d89
1 changed files with 6 additions and 2 deletions

8
valence/common/redfish/api.py

@ -159,7 +159,10 @@ def urls2list(url):
# This will extract the url values from @odata.id inside Members
resp = send_request(url)
respdata = resp.json()
return [u['@odata.id'] for u in respdata['Members']]
if 'Members' in respdata:
return [u['@odata.id'] for u in respdata['Members']]
else:
return []
def extract_val(data, path):
@ -397,7 +400,8 @@ def nodes_list(count=None, filters={}):
if "Memory" in node:
ram = node["Memory"]["TotalSystemMemoryGiB"]
if "EthernetInterfaces" in node["Links"]:
if "EthernetInterfaces" in node["Links"] and node[
"Links"]["EthernetInterfaces"]:
nw = len(node["Links"]["EthernetInterfaces"])
bmcip = "127.0.0.1" # system['Oem']['Dell_G5MC']['BmcIp']