Enable gating on E127

Enables gating on 'continuation line overindented for visual indent' and
fixes existing violations.

Change-Id: I1ba4cc8108409f73080303c55a0e233a3505e1db

tox.ini

@@ -30,6 +30,6 @@ commands = {posargs}
 
 [flake8]
 # H302 import only modules.
-ignore = E127,E128,H302
+ignore = E128,H302
 builtins = _
 exclude =  .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools

tuskar/api/controllers/v1/overcloud_roles.py

@@ -140,5 +140,5 @@ class OvercloudRolesController(rest.RestController):
         LOG.debug('Retrieving all overcloud roles')
         db_roles = pecan.request.dbapi.get_overcloud_roles()
         transfer_roles = [models.OvercloudRole.from_db_model(c)
-                               for c in db_roles]
+                          for c in db_roles]
         return transfer_roles

tuskar/cmd/api.py

@@ -52,10 +52,12 @@ def main():
     try:
         os.listdir(heat_template_path)
     except OSError:
-        LOG.info("Can't find local tripleo-heat-template files at %s"
-                  % (heat_template_path))
-        LOG.info("Cannot proceed - missing tripleo heat templates " +
-                  "See INSTALL documentation for more info")
+        LOG.info(
+            "Can't find local tripleo-heat-template files at %s"
+            % (heat_template_path))
+        LOG.info(
+            "Cannot proceed - missing tripleo heat templates "
+            "See INSTALL documentation for more info")
         raise
     LOG.info("Using tripleo-heat-templates at %s" % (heat_template_path))
 

tuskar/manager/manager.py

@@ -40,8 +40,8 @@ class ManagerService(service.PeriodicService):
         # TODO(deva)
 
     def process_notification(self, notification):
-        LOG.debug(_('Received notification: %r') %
-                        notification.get('event_type'))
+        LOG.debug(
+            _('Received notification: %r') % notification.get('event_type'))
         # TODO(deva)
 
     def periodic_tasks(self, context):

tuskar/tests/base.py

@@ -66,8 +66,8 @@ _DB_CACHE = None
 
 class Database(fixtures.Fixture):
 
-    def __init__(self, db_session, db_migrate, sql_connection,
-                    sqlite_db, sqlite_clean_db):
+    def __init__(self, db_session, db_migrate, sql_connection, sqlite_db,
+                 sqlite_clean_db):
         self.sql_connection = sql_connection
         self.sqlite_db = sqlite_db
         self.sqlite_clean_db = sqlite_clean_db
@@ -176,10 +176,12 @@ class TestCase(testtools.TestCase, unittest2.TestCase):
 
         global _DB_CACHE
         if not _DB_CACHE:
-            _DB_CACHE = Database(session, migration,
-                                    sql_connection=CONF.database.connection,
-                                    sqlite_db=CONF.sqlite_db,
-                                    sqlite_clean_db=CONF.sqlite_clean_db)
+            _DB_CACHE = Database(
+                session, migration,
+                sql_connection=CONF.database.connection,
+                sqlite_db=CONF.sqlite_db,
+                sqlite_clean_db=CONF.sqlite_clean_db
+            )
         self.useFixture(_DB_CACHE)
 
         mox_fixture = self.useFixture(MoxStubout())

tuskar/tests/test_utils.py

@@ -58,8 +58,8 @@ class GenericUtilsTestCase(base.TestCase):
             self.assertEqual(reloaded_data, fake_contents)
             self.reload_called = True
 
-        data = utils.read_cached_file("/this/is/a/fake", cache_data,
-                                                reload_func=test_reload)
+        data = utils.read_cached_file(
+            "/this/is/a/fake", cache_data, reload_func=test_reload)
         self.assertEqual(data, fake_contents)
         self.assertTrue(self.reload_called)