x/tobiko
Code Issues Proposed changes

Pass pylint test with unit tests.

Browse Source 
Change-Id: Ib11daf240201147e5568f184283e7d138b3b7166
This commit is contained in:
Federico Ressi 2018-11-27 10:32:04 +01:00
parent 343be33fe7
commit 838ad9e18b
3 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tobiko/tests/cmd/test_create.py
View File

@ -60,16 +60,19 @@ class TestMain(TobikoTest):
@mock.patch('sys.argv', ['tobiko-create', '--stack', 'test_floatingip'])
def test_main_with_stack(self):
# pylint: disable=no-value-for-parameter
self._test_main(stack_names=['test_floatingip'],
walk_dir=False)
@mock.patch('sys.argv', ['tobiko-create'])
def test_main(self):
# pylint: disable=no-value-for-parameter
self._test_main(stack_names=['test_floatingip', 'test_mtu'],
walk_dir=True)
@mock.patch('sys.argv', ['tobiko-create', '--all'])
def test_main_with_all(self):
# pylint: disable=no-value-for-parameter
self._test_main(stack_names=['test_mtu', 'test_security_groups'],
walk_dir=True)

3
tobiko/tests/cmd/test_delete.py
View File

@ -60,16 +60,19 @@ class TestMain(TobikoTest):
@mock.patch('sys.argv', ['tobiko-delete', '--stack', 'test_floatingip'])
def test_main_with_stack(self):
# pylint: disable=no-value-for-parameter
self._test_main(stack_names=['test_floatingip'],
walk_dir=False)
@mock.patch('sys.argv', ['tobiko-delete'])
def test_main(self):
# pylint: disable=no-value-for-parameter
self._test_main(stack_names=['test_floatingip', 'test_mtu'],
walk_dir=True)
@mock.patch('sys.argv', ['tobiko-delete', '--all'])
def test_main_with_all(self):
# pylint: disable=no-value-for-parameter
self._test_main(stack_names=['test_mtu', 'test_security_groups',
'test_floatingip'],
walk_dir=True)

15
tobiko/tests/cmd/test_list.py
View File

@ -18,7 +18,7 @@ import os.path
import mock
from tobiko.cmd import list
from tobiko.cmd import list as list_cmd
from tobiko.common import constants
from tobiko.tests.base import TobikoTest
@ -27,7 +27,7 @@ class ListUtilTest(TobikoTest):
@mock.patch('sys.argv', ['tobiko-list'])
def test_init(self):
cmd = list.ListUtil()
cmd = list_cmd.ListUtil()
self.assertIsNotNone(cmd.clientManager)
self.assertTrue(os.path.isdir(cmd.templates_dir))
self.assertIsNotNone(cmd.stackManager)
@ -43,7 +43,7 @@ class ListUtilTest(TobikoTest):
self._test_init_with_stacks()
def _test_init_with_stacks(self):
cmd = list.ListUtil()
cmd = list_cmd.ListUtil()
self.assertIsNotNone(cmd.clientManager)
self.assertTrue(os.path.isdir(cmd.templates_dir))
self.assertIsNotNone(cmd.stackManager)
@ -59,7 +59,7 @@ class ListUtilTest(TobikoTest):
self._test_init_with_templates()
def _test_init_with_templates(self):
cmd = list.ListUtil()
cmd = list_cmd.ListUtil()
self.assertIsNotNone(cmd.clientManager)
self.assertTrue(os.path.isdir(cmd.templates_dir))
self.assertIsNotNone(cmd.stackManager)
@ -71,26 +71,31 @@ class TestMain(TobikoTest):
@mock.patch('sys.argv', ['tobiko-list'])
def test_main(self):
# pylint: disable=no-value-for-parameter
self._test_main(stack_names=['test_floatingip', 'test_mtu'],
show_templates=True)
@mock.patch('sys.argv', ['tobiko-list', '--stack'])
def test_main_with_stacks(self):
# pylint: disable=no-value-for-parameter
self._test_main(stack_names=['test_floatingip', 'test_mtu'],
show_templates=False)
@mock.patch('sys.argv', ['tobiko-list', '-s'])
def test_main_with_s(self):
# pylint: disable=no-value-for-parameter
self._test_main(stack_names=['test_floatingip', 'test_mtu'],
show_templates=False)
@mock.patch('sys.argv', ['tobiko-list', '--templates'])
def test_main_with_templates(self):
# pylint: disable=no-value-for-parameter
self._test_main(stack_names=['test_floatingip', 'test_mtu'],
show_templates=True)
@mock.patch('sys.argv', ['tobiko-list', '-t'])
def test_main_with_all(self):
# pylint: disable=no-value-for-parameter
self._test_main(stack_names=['test_floatingip', 'test_mtu'],
show_templates=True)
@ -107,7 +112,7 @@ class TestMain(TobikoTest):
mock.Mock(stack_name=stack_name)
for stack_name in stack_names[::2]]
list.main()
list_cmd.main()
if show_templates:
mock_write.assert_has_calls([mock.call(stack_name + '.yaml\n')