x/tobiko
Code Issues Proposed changes

Improve ping command tracing.

Browse Source 
Change-Id: If2cd8e546c7f618b889397147111b12e85b4ff7a
This commit is contained in:
Federico Ressi 2018-12-04 18:33:01 +01:00
parent 3fc234c807
commit 835b1aa854
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tobiko/common/utils/network.py
View File

@ -111,12 +111,18 @@ def ping_ip_address(ip_address, should_succeed=True,
LOG.debug('Execute ping command: %r', cmd_line)
proc = subprocess.Popen(cmd_line,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE)
stderr=subprocess.PIPE,
universal_newlines=True)
stdout, stderr = proc.communicate()
LOG.debug('Ping command exit status: %d', proc.returncode)
LOG.debug('Ping command stderr:\n%s', stderr)
LOG.debug('Ping command stdout:\n%s', stdout)
return (proc.returncode == 0) == should_succeed
if proc.returncode == 0:
LOG.debug("Ping command succeeded:\n"
"stdout:\n%s\n"
"stderr:\n%s\n", stdout, stderr)
return should_succeed
else:
LOG.debug("Ping command failed (exit_status=%d):\n"
"stdout:\n%s\n"
"stderr:\n%s\n", proc.returncode, stdout, stderr)
return not should_succeed
return test_utils.call_until_true(ping, timeout, 1)