Fix tobiko-devstack role

Change-Id: I9b3625701cbf3d4b16222f1a61de32cc6148d453

roles/tobiko-devstack/defaults/main.yaml

@@ -10,4 +10,4 @@ devstack_tobiko_dir: '{{ devstack_dest_dir }}/tobiko'
 
 devstack_src_dir: '{{ devstack_workspace_dir }}/devstack'
 
-sudo_secure_path: '/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'
+sudo_secure_path: ''

roles/tobiko-devstack/tasks/ensure-stack-user.yaml

@@ -1,13 +1,5 @@
 ---
 
-- name: ensure /usr/local/bin is in sudo secure path
-  become: yes
-  lineinfile:
-    path: /etc/sudoers
-    regexp: 'secure_path'
-    line: 'Defaults    secure_path = /sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin'
-    validate: '/usr/sbin/visudo -cf %s'
-
 
 - name: ensure stack group exists
   become: yes

roles/tobiko-devstack/tasks/run-stack.yaml

@@ -3,14 +3,18 @@
 - name: run stack.sh
   become: yes
   become_user: stack
-  command:
+  shell:
-    cmd: /bin/bash ./stack.sh
+    cmd: |
+      source /etc/profile
+      ./stack.sh 2>&1
+      rc=$?
+      echo "*** FINISHED ***"
+      exit $rc
     chdir: '{{ devstack_dir }}'
-    executable: '/bin/bash'
   register: run_stack
   ignore_errors: yes
 
 
 - name: show stack.sh output
-  debug: var=run_stack.stderr_lines
+  debug: var=run_stack.stdout_lines
-  failed_when: yes
+  failed_when: run_stack is failed

roles/tobiko-devstack/tasks/run-unstack.yaml

@@ -10,8 +10,13 @@
 - name: run unstack.sh
   become: yes
   become_user: stack
-  command:
+  shell:
-    cmd: /bin/bash ./unstack.sh
+    cmd: |
+      source /etc/profile
+      ./unstack.sh 2>&1
+      rc=$?
+      echo "*** FINISHED ***"
+      exit $rc
     chdir: '{{ devstack_dir }}'
   register: run_unstack
   ignore_errors: yes
@@ -19,5 +24,5 @@
     check_devstack_local_conf_file_exists.stat.exists | default(False)
 
 
-- debug: var=run_unstack.stderr_lines
+- debug: var=run_unstack.stdout_lines
   when: run_unstack is failed