x/tobiko
Code Issues Proposed changes

Fix Octavia HA test_stop_haproxy

Browse Source 
So far, test_stop_haproxy failed randomly because amp_haproxy_unit was
not returned, randomly. When that happened, the test failed, as it tried
to stop the '' service/unit.

This patch wraps the amp_haproxy_unit retrieval in a tobiko.retry
mechanism.

Change-Id: Ifa987a32c22ac8050adb7ba2ac76b4e90bac9597
This commit is contained in:
Omer 2023-08-30 15:48:17 +02:00
parent b32c3a5f6e
commit 171016d467
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tobiko/tests/faults/octavia/test_faults.py
View File

@ -179,10 +179,22 @@ class OctaviaBasicFaultTest(testtools.TestCase):
# Finding the amphora haproxy unit name and stop it
amp_haproxy_unit_command = (
"systemctl list-units | awk '/haproxy-/{print $1}'")
amp_haproxy_unit = octavia.run_command_on_amphora(
command=amp_haproxy_unit_command,
lb_id=self.lb.id,
lb_vip=self.lb.vip_address)
for attempt in tobiko.retry(timeout=300., interval=5.):
amp_haproxy_unit = octavia.run_command_on_amphora(
command=amp_haproxy_unit_command,
lb_id=self.lb.id,
lb_vip=self.lb.vip_address)
if amp_haproxy_unit:
break
# it will raise tobiko.RetryTimeLimitError in case of timeout
attempt.check_limits()
LOG.debug(f"Waiting for haproxy instance on LB {self.lb.id} to get"
" the haproxy unit id")
LOG.info(f'The amp_haproxy_unit is {amp_haproxy_unit}')
octavia.run_command_on_amphora(