7a73fd7f9f
In this commit we add several unit tests that covers some managers. We chose to write unit tests for managers that are closest to Synergy core functionalities in a first stage. Also, we test only method specific to each manager as the base methods of Manager class have been tested in Synergy. Managers with unit tests: - FairShareManager - QueueManager - QuotaManager (and DynamicQuota) - SchedulerManager Change-Id: I831649e48b36bbaf94f6790fbf1a8954636fac32
336 lines
12 KiB
Python
336 lines
12 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import heapq
|
|
|
|
from mock import call
|
|
from mock import create_autospec
|
|
from mock import patch
|
|
from sqlalchemy.engine.base import Engine
|
|
|
|
from synergy_scheduler_manager.fairshare_manager import FairShareManager
|
|
from synergy_scheduler_manager.queue_manager import PriorityQueue
|
|
from synergy_scheduler_manager.queue_manager import Queue
|
|
from synergy_scheduler_manager.queue_manager import QueueItem
|
|
from synergy_scheduler_manager.tests.unit import base
|
|
|
|
|
|
class TestQueueItem(base.TestCase):
|
|
|
|
def test_get_set_id(self):
|
|
qitem = QueueItem(id=1,
|
|
user_id=None,
|
|
prj_id=None,
|
|
priority=None,
|
|
retry_count=None,
|
|
creation_time=None,
|
|
last_update=None,
|
|
data=None)
|
|
|
|
self.assertEqual(1, qitem.getId())
|
|
|
|
qitem.setId(10)
|
|
self.assertEqual(10, qitem.getId())
|
|
|
|
def test_get_set_userid(self):
|
|
qitem = QueueItem(id=None,
|
|
user_id=1,
|
|
prj_id=None,
|
|
priority=None,
|
|
retry_count=None,
|
|
creation_time=None,
|
|
last_update=None,
|
|
data=None)
|
|
|
|
self.assertEqual(1, qitem.getUserId())
|
|
|
|
qitem.setUserId(10)
|
|
self.assertEqual(10, qitem.getUserId())
|
|
|
|
def test_get_set_projectid(self):
|
|
qitem = QueueItem(id=None,
|
|
user_id=None,
|
|
prj_id=1,
|
|
priority=None,
|
|
retry_count=None,
|
|
creation_time=None,
|
|
last_update=None,
|
|
data=None)
|
|
|
|
self.assertEqual(1, qitem.getProjectId())
|
|
|
|
qitem.setProjectId(10)
|
|
self.assertEqual(10, qitem.getProjectId())
|
|
|
|
def test_get_set_priority(self):
|
|
qitem = QueueItem(id=None,
|
|
user_id=None,
|
|
prj_id=None,
|
|
priority=1,
|
|
retry_count=None,
|
|
creation_time=None,
|
|
last_update=None,
|
|
data=None)
|
|
|
|
self.assertEqual(1, qitem.getPriority())
|
|
|
|
qitem.setPriority(10)
|
|
self.assertEqual(10, qitem.getPriority())
|
|
|
|
def test_retry_count(self):
|
|
qitem = QueueItem(id=None,
|
|
user_id=None,
|
|
prj_id=None,
|
|
priority=None,
|
|
retry_count=1,
|
|
creation_time=None,
|
|
last_update=None,
|
|
data=None)
|
|
|
|
self.assertEqual(1, qitem.getRetryCount())
|
|
|
|
qitem.setRetryCount(10)
|
|
self.assertEqual(10, qitem.getRetryCount())
|
|
|
|
qitem.incRetryCount()
|
|
self.assertEqual(11, qitem.getRetryCount())
|
|
|
|
def test_get_set_creation_time(self):
|
|
qitem = QueueItem(id=None,
|
|
user_id=None,
|
|
prj_id=None,
|
|
priority=None,
|
|
retry_count=None,
|
|
creation_time="now",
|
|
last_update=None,
|
|
data=None)
|
|
|
|
self.assertEqual("now", qitem.getCreationTime())
|
|
|
|
qitem.setCreationTime("later")
|
|
self.assertEqual("later", qitem.getCreationTime())
|
|
|
|
def test_get_set_last_update(self):
|
|
qitem = QueueItem(id=None,
|
|
user_id=None,
|
|
prj_id=None,
|
|
priority=None,
|
|
retry_count=None,
|
|
creation_time=None,
|
|
last_update="now",
|
|
data=None)
|
|
|
|
self.assertEqual("now", qitem.getLastUpdate())
|
|
|
|
qitem.setLastUpdate("later")
|
|
self.assertEqual("later", qitem.getLastUpdate())
|
|
|
|
def test_get_set_data(self):
|
|
qitem = QueueItem(id=None,
|
|
user_id=None,
|
|
prj_id=None,
|
|
priority=None,
|
|
retry_count=None,
|
|
creation_time=None,
|
|
last_update=None,
|
|
data=1)
|
|
|
|
self.assertEqual(1, qitem.getData())
|
|
|
|
qitem.setData(2)
|
|
self.assertEqual(2, qitem.getData())
|
|
|
|
|
|
class TestPriorityQueue(base.TestCase):
|
|
|
|
def test_put(self):
|
|
pq = PriorityQueue()
|
|
pq.put(0, "a")
|
|
pq.put(5, "b")
|
|
pq.put(10, "c")
|
|
|
|
self.assertIn((0, 0, "a"), pq.queue)
|
|
self.assertIn((-5, 1, "b"), pq.queue)
|
|
self.assertIn((-10, 2, "c"), pq.queue)
|
|
|
|
self.assertEqual(3, pq._index)
|
|
|
|
self.assertEqual((-10, 2, "c"), heapq.heappop(pq.queue))
|
|
self.assertEqual((-5, 1, "b"), heapq.heappop(pq.queue))
|
|
self.assertEqual((0, 0, "a"), heapq.heappop(pq.queue))
|
|
|
|
def test_get(self):
|
|
pq = PriorityQueue()
|
|
pq.put(0, "a")
|
|
pq.put(5, "b")
|
|
|
|
self.assertEqual("b", pq.get())
|
|
self.assertEqual("a", pq.get())
|
|
|
|
def test_size(self):
|
|
pq = PriorityQueue()
|
|
pq.put(0, "a")
|
|
pq.put(5, "b")
|
|
pq.put(10, "c")
|
|
|
|
self.assertEqual(3, pq.size())
|
|
|
|
|
|
class TestQueue(base.TestCase):
|
|
|
|
def setUp(self):
|
|
super(TestQueue, self).setUp()
|
|
|
|
# Create a Queue that mocks database interaction
|
|
self.db_engine_mock = create_autospec(Engine)
|
|
self.q = Queue(name="test", db_engine=self.db_engine_mock)
|
|
|
|
def test_insert_item(self):
|
|
self.q.insertItem(user_id=1, prj_id=2, priority=10, data="mydata")
|
|
|
|
# Check the db call of the item insert
|
|
insert_call = call.connect().execute(
|
|
'insert into `test` (user_id, prj_id, priority, data) '
|
|
'values(%s, %s, %s, %s)', [1, 2, 10, '"mydata"'])
|
|
self.assertIn(insert_call, self.db_engine_mock.mock_calls)
|
|
|
|
# Check the item existence and values in the in-memory queue
|
|
priority, index, item = heapq.heappop(self.q.pqueue.queue)
|
|
self.assertEqual(-10, priority)
|
|
self.assertEqual(0, index)
|
|
self.assertEqual(1, item.user_id)
|
|
self.assertEqual(2, item.prj_id)
|
|
self.assertEqual(10, item.priority)
|
|
self.assertEqual(0, item.retry_count)
|
|
self.assertIsNone(item.data) # TODO(vincent): should it be "mydata"?
|
|
|
|
def test_get_size(self):
|
|
execute_mock = self.db_engine_mock.connect().execute
|
|
execute_call = call('select count(*) from `test`')
|
|
|
|
fetchone_mock = execute_mock().fetchone
|
|
fetchone_mock.return_value = [3]
|
|
|
|
# Check that getSize() uses the correct sqlalchemy method
|
|
self.assertEqual(3, self.q.getSize())
|
|
|
|
# Check that getSize() uses the correct SQL statement
|
|
self.assertEqual(execute_call, execute_mock.call_args)
|
|
|
|
def test_reinsert_item(self):
|
|
# TODO(vincent): what is the purpose of this method?
|
|
# It will lead to duplicates.
|
|
pass
|
|
|
|
def test_get_item(self):
|
|
# Insert the item and mock its DB insertion
|
|
execute_mock = self.db_engine_mock.connect().execute
|
|
execute_mock().lastrowid = 123
|
|
self.q.insertItem(user_id=1, prj_id=2, priority=10, data="mydata")
|
|
|
|
# Mock the DB select by returning the same things we inserted before
|
|
select_mock = self.db_engine_mock.connect().execute
|
|
select_call = call("select user_id, prj_id, priority, retry_count, "
|
|
"creation_time, last_update, data from `test` "
|
|
"where id=%s", [123])
|
|
fetchone_mock = select_mock().fetchone
|
|
fetchone_mock.return_value = [1, 2, 10, 0, "now", "now", '"mydata"']
|
|
|
|
item = self.q.getItem()
|
|
self.assertEqual(select_call, select_mock.call_args)
|
|
self.assertEqual(123, item.id)
|
|
self.assertEqual(1, item.user_id)
|
|
self.assertEqual(2, item.prj_id)
|
|
self.assertEqual(10, item.priority)
|
|
self.assertEqual(0, item.retry_count)
|
|
self.assertEqual("now", item.creation_time)
|
|
self.assertEqual("now", item.last_update)
|
|
self.assertEqual("mydata", item.data)
|
|
|
|
def test_delete_item(self):
|
|
# Mock QueueItem to be deleted
|
|
qitem = create_autospec(QueueItem)
|
|
qitem.getId.return_value = 123
|
|
|
|
# Mock the DB delete
|
|
execute_mock = self.db_engine_mock.connect().execute
|
|
execute_call = call("delete from `test` where id=%s", [123])
|
|
|
|
self.q.deleteItem(qitem)
|
|
self.assertEqual(execute_call, execute_mock.call_args)
|
|
|
|
def test_update_item(self):
|
|
# Mock QueueItem to be updated
|
|
qitem = create_autospec(QueueItem)
|
|
qitem.getPriority.return_value = 10
|
|
qitem.getRetryCount.return_value = 20
|
|
qitem.getLastUpdate.return_value = "right_now"
|
|
qitem.getId.return_value = 123
|
|
|
|
# Mock the DB update
|
|
execute_mock = self.db_engine_mock.connect().execute
|
|
execute_call = call("update `test` set priority=%s, retry_count=%s, "
|
|
"last_update=%s where id=%s",
|
|
[10, 20, "right_now", 123])
|
|
|
|
# Check the DB call and that the new QueueItem is in the queue
|
|
self.q.updateItem(qitem)
|
|
self.assertEqual(execute_call, execute_mock.call_args)
|
|
self.assertIn((-10, 0, qitem), self.q.pqueue.queue)
|
|
|
|
def test_update_priority(self):
|
|
qitem1 = QueueItem(
|
|
id=1,
|
|
user_id=None,
|
|
prj_id=None,
|
|
priority=0,
|
|
retry_count=None,
|
|
creation_time="0AC",
|
|
last_update="before")
|
|
qitem2 = QueueItem(
|
|
id=2,
|
|
user_id=None,
|
|
prj_id=None,
|
|
priority=10,
|
|
retry_count=None,
|
|
creation_time="0AC",
|
|
last_update="before")
|
|
|
|
# TODO(vincent): priority on an item & priority in the queue,
|
|
# shouldn't it be the same thing?
|
|
self.q.pqueue.put(0, qitem1)
|
|
self.q.pqueue.put(10, qitem2)
|
|
|
|
# Mock fairshare_mgr to fake computing the priority
|
|
self.q.fairshare_manager = create_autospec(FairShareManager)
|
|
self.q.fairshare_manager.execute.side_effect = [200, 100] # new prio.
|
|
|
|
# Mock DB update call
|
|
execute_mock = self.db_engine_mock.connect().execute
|
|
execute_call1 = call("update `test` set priority=%s, last_update=%s "
|
|
"where id=%s", [200, "now", 2])
|
|
execute_call2 = call("update `test` set priority=%s, last_update=%s "
|
|
"where id=%s", [100, "now", 1])
|
|
|
|
# Mock datetime.now() call so it is predictable
|
|
with patch("synergy_scheduler_manager.queue_manager.datetime") as mock:
|
|
mock.now.return_value = "now"
|
|
self.q.updatePriority()
|
|
|
|
# Check that that fsmanager.execute was correctly called
|
|
self.assertIn(execute_call1, execute_mock.call_args_list)
|
|
self.assertIn(execute_call2, execute_mock.call_args_list)
|
|
|
|
# Check new QueueItem with updated priority are in the pqueue
|
|
self.assertEqual(200, qitem2.priority)
|
|
self.assertEqual(100, qitem1.priority)
|