From dfb591683315c6b999b16232607fba9af5f6ea25 Mon Sep 17 00:00:00 2001 From: Thomas Maddox Date: Fri, 13 Sep 2013 11:25:32 -0500 Subject: [PATCH] small tweak --- reports/error_details.py | 7 +++---- reports/pretty.py | 8 +++----- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/reports/error_details.py b/reports/error_details.py index 590f4b8..9cc83d1 100644 --- a/reports/error_details.py +++ b/reports/error_details.py @@ -169,10 +169,9 @@ if __name__ == '__main__': for request in requests: uuid = request['instance'] request_id = request['request_id'] - if uuid in inst_recs: - inst_recs[uuid].append(request_id) - else: - inst_recs[uuid] = [request_id] + value = inst_recs.get(uuid, []) + value.append(request_id) + inst_recs[uuid] = value for uuid_dict in updates: uuid = uuid_dict['instance'] diff --git a/reports/pretty.py b/reports/pretty.py index 1303f5f..1cd1fe8 100644 --- a/reports/pretty.py +++ b/reports/pretty.py @@ -61,11 +61,9 @@ def make_report(yesterday=None, start_hour=0, hours=24, percentile=97, for request in requests: uuid = request['instance'] request_id = request['request_id'] - if uuid in inst_recs: - inst_recs[uuid].append(request_id) - else: - inst_recs[uuid] = [request_id] - + value = inst_recs.get(uuid, []) + value.append(request_id) + inst_recs[uuid] = value failures = {} # { key : {failure_type: count} } durations = {}