x/stackalytics
Code Issues Proposed changes

Verify that empty email is not added into user profile

Browse Source 
Closes bug #1228107

Change-Id: I5ad0cf0ba0bacc50419c01f46623d30b38574305
This commit is contained in:
Ilya Shakhat 2013-09-20 16:34:50 +04:00
parent 18126be91e
commit 9c858cfb6a
2 changed files with 45 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
stackalytics/processor/record_processor.py
View File

@ -154,7 +154,8 @@ class RecordProcessor(object):
if (launchpad_id) and (launchpad_id in self.users_index): if (launchpad_id) and (launchpad_id in self.users_index):
# merge emails # merge emails
user = self.users_index[launchpad_id] user = self.users_index[launchpad_id]
self._update_user_profile(user, email) if email:
self._update_user_profile(user, email)
else: else:
# create new # create new
if not user_name: if not user_name:

43
tests/unit/test_record_processor.py
View File

@ -468,6 +468,49 @@ class TestRecordProcessor(testtools.TestCase):
self.assertEquals({'john_doe': user, 'john_doe@gmail.com': user}, self.assertEquals({'john_doe': user, 'john_doe@gmail.com': user},
record_processor_inst.users_index) record_processor_inst.users_index)
def test_process_review_then_blueprint(self):
record_processor_inst = self.make_record_processor(
lp_user_name={
'john_doe': {'name': 'john_doe', 'display_name': 'John Doe'}})
processed_records = list(record_processor_inst.process([
{'record_type': 'review',
'id': 'I1045730e47e9e6ad31fcdfbaefdad77e2f3b2c3e',
'subject': 'Fix AttributeError in Keypair._add_details()',
'owner': {'name': 'John Doe',
'email': 'john_doe@gmail.com',
'username': 'john_doe'},
'createdOn': 1379404951,
'module': 'nova'},
{'record_type': 'bp',
'self_link': 'http://launchpad.net/blueprint',
'owner': 'john_doe',
'date_created': 1234567890}
]))
self.assertRecordsMatch(
{'record_type': 'review',
'launchpad_id': 'john_doe',
'author_name': 'John Doe',
'author_email': 'john_doe@gmail.com',
'company_name': '*independent'},
processed_records[0])
self.assertRecordsMatch(
{'record_type': 'bpd',
'launchpad_id': 'john_doe',
'author_name': 'John Doe',
'company_name': '*independent'},
processed_records[1])
user = {'user_id': 'john_doe',
'launchpad_id': 'john_doe',
'user_name': 'John Doe',
'emails': ['john_doe@gmail.com'],
'companies': [{'company_name': '*independent', 'end_date': 0}]}
self.assertEquals({'john_doe': user, 'john_doe@gmail.com': user},
record_processor_inst.users_index)
# update records # update records
def _generate_record_commit(self): def _generate_record_commit(self):