x/stackalytics
Code Issues Proposed changes

Minor fixes in KPI report wording

Browse Source 
Change-Id: I2bbdd52ff5442f42cd2e99890b5b8c5fd4027c82
This commit is contained in:
Ilya Shakhat 2013-12-26 21:04:13 +04:00
parent 9dc21b6840
commit 78fefcd894
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
dashboard/templates/kpi/base_kpi.html
View File

@ -46,7 +46,7 @@
success: function (data) { success: function (data) {
data = data["stats"]; data = data["stats"];
var position = -1; var position = -1;
var index = -1; var index = 0;
var sum = 0; var sum = 0;
for (var i = 0; i < data.length; i++) { for (var i = 0; i < data.length; i++) {
@ -56,11 +56,9 @@
} }
} }
sum += data[i].metric; sum += data[i].metric;
if (data[i].index) { data[i].index = ++ index; // re-index
index ++;
}
if (data[i].id == item_id) { if (data[i].id == item_id) {
position = index; position = i;
} }
} }
@ -105,7 +103,7 @@
return { return {
mark: mark, mark: mark,
info: mark? "Achieved metric " + item.metric: info: mark? "Achieved metric " + item.metric:
"Position " + item.metric + " is worse than the goal in " + metric, "Metric " + item.metric + " is worse than the goal in " + metric,
value: item.index value: item.index
} }
}); });