From 658d2e5ffe27055c87c87cff0a40cab9aa096bc0 Mon Sep 17 00:00:00 2001 From: "Swapnil Kulkarni (coolsvap)" Date: Mon, 4 Jan 2016 19:49:30 +0530 Subject: [PATCH] Replace assertEqual(None, *) with assertIsNone in tests Replace assertEqual(None, *) with assertIsNone in tests to have more clear messages in case of failure. Change-Id: I834ec0fd6d335383ee2ef71efe8cd51a25a22650 Partial-bug: #1280522 --- stackalytics/tests/unit/test_record_processor.py | 6 +++--- stackalytics/tests/unit/test_utils.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/stackalytics/tests/unit/test_record_processor.py b/stackalytics/tests/unit/test_record_processor.py index d5274385e..2cd003ca4 100644 --- a/stackalytics/tests/unit/test_record_processor.py +++ b/stackalytics/tests/unit/test_record_processor.py @@ -105,7 +105,7 @@ class TestRecordProcessor(testtools.TestCase): record_processor_inst = self.make_record_processor() email = 'foo@boo.com' res = record_processor_inst._get_company_by_email(email) - self.assertEqual(None, res) + self.assertIsNone(res) # get_lp_info @@ -387,7 +387,7 @@ class TestRecordProcessor(testtools.TestCase): user_id='johndoe@ibm.com') self.assertIn('johndoe@ibm.com', user['emails']) self.assertEqual('IBM', user['companies'][0]['company_name']) - self.assertEqual(None, user['launchpad_id']) + self.assertIsNone(user['launchpad_id']) def test_process_review_new_user(self): # User is known to LP, but new to us @@ -1023,7 +1023,7 @@ class TestRecordProcessor(testtools.TestCase): 'companies': [{'company_name': 'IBM', 'end_date': 0}]} runtime_storage_inst = record_processor_inst.runtime_storage_inst self.assertEqual(2, runtime_storage_inst.get_by_key('user:count')) - self.assertEqual(None, user_processor.load_user( + self.assertIsNone(user_processor.load_user( runtime_storage_inst, 1)) self.assertEqual(user, user_processor.load_user( runtime_storage_inst, 2)) diff --git a/stackalytics/tests/unit/test_utils.py b/stackalytics/tests/unit/test_utils.py index 2b5c72ce4..35e51a4c9 100644 --- a/stackalytics/tests/unit/test_utils.py +++ b/stackalytics/tests/unit/test_utils.py @@ -123,7 +123,7 @@ class TestUtils(testtools.TestCase): profile = None utils.validate_lp_display_name(profile) - self.assertEqual(None, profile) + self.assertIsNone(profile) def test_pipeline_processor(self): counter = dict(n=0)