x/sqlalchemy-migrate
Code Issues Proposed changes

work around firebird's insistence that indexes and constraints are dropped before columns that are references by them.

Browse Source
This commit is contained in:
Chris Withers 2011-02-10 15:19:00 +00:00
parent 500cb6f5df
commit c80120da55
1 changed files with 21 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
migrate/changeset/databases/firebird.py
View File

@ -2,7 +2,7 @@
Firebird database specific implementations of changeset classes. Firebird database specific implementations of changeset classes.
""" """
from sqlalchemy.databases import firebird as sa_base from sqlalchemy.databases import firebird as sa_base
from sqlalchemy.schema import PrimaryKeyConstraint
from migrate import exceptions from migrate import exceptions
from migrate.changeset import ansisql, SQLA_06 from migrate.changeset import ansisql, SQLA_06
@ -27,13 +27,27 @@ class FBColumnDropper(ansisql.ANSIColumnDropper):
if column.table.primary_key.columns.contains_column(column): if column.table.primary_key.columns.contains_column(column):
column.table.primary_key.drop() column.table.primary_key.drop()
# TODO: recreate primary key if it references more than this column # TODO: recreate primary key if it references more than this column
if column.unique or getattr(column, 'unique_name', None):
for index in column.table.indexes:
# "column in index.columns" causes problems as all
# column objects compare equal and return a SQL expression
if column.name in [col.name for col in index.columns]:
index.drop()
# TODO: recreate index if it references more than this column
for cons in column.table.constraints: for cons in column.table.constraints:
if cons.contains_column(column): if isinstance(cons,PrimaryKeyConstraint):
cons.drop() # will be deleted only when the column its on
# is deleted!
continue
if cons.contains_column(column) and cons.name:
self.start_alter_table(column)
self.append("DROP CONSTRAINT ")
self.append(self.preparer.format_constraint(cons))
self.execute()
# TODO: recreate unique constraint if it refenrences more than this column # TODO: recreate unique constraint if it refenrences more than this column
table = self.start_alter_table(column) self.start_alter_table(column)
self.append('DROP %s' % self.preparer.format_column(column)) self.append('DROP %s' % self.preparer.format_column(column))
self.execute() self.execute()