x/rsd-lib
Code Issues Proposed changes

Remove unnecessary __init__ method

Browse Source 
Change-Id: Id9a555caa1fa82840f37bef7b6e2b65106142cef
This commit is contained in:
Lin Yang 2019-05-24 09:39:56 -07:00
parent 5731010d0e
commit f810ae597c
26 changed files with 0 additions and 385 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
rsd_lib/resources/v2_1/fabric/port.py
View File

@ -133,16 +133,6 @@ class Port(rsd_lib_base.ResourceBase):
actions = ActionsField("Actions")
"""The port actions"""
def __init__(self, connector, identity, redfish_version=None):
"""A class representing a Port
:param connector: A Connector instance
:param identity: The identity of the Port resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(Port, self).__init__(connector, identity, redfish_version)
def _get_reset_action_element(self):
reset_action = self.actions.reset
if not reset_action:

12
rsd_lib/resources/v2_1/system/network_interface.py
View File

@ -32,18 +32,6 @@ class NetworkInterface(rsd_lib_base.ResourceBase):
enabled.
"""
def __init__(self, connector, identity, redfish_version=None):
"""A class representing a NetworkInterface
:param connector: A Connector instance
:param identity: The identity of the NetworkInterface
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(NetworkInterface, self).__init__(
connector, identity, redfish_version
)
@property
@utils.cache_it
def network_device_functions(self):

13
rsd_lib/resources/v2_2/ethernet_switch/ethernet_switch.py
View File

@ -60,16 +60,3 @@ class EthernetSwitchCollection(base.ResourceCollectionBase):
@property
def _resource_type(self):
return EthernetSwitch
def __init__(self, connector, path, redfish_version=None):
"""A class representing a EthernetSwitch Collection
:param connector: A Connector instance
:param path: The canonical path to the EthernetSwitch collection
resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(EthernetSwitchCollection, self).__init__(
connector, path, redfish_version
)

12
rsd_lib/resources/v2_2/manager/manager.py
View File

@ -42,15 +42,3 @@ class ManagerCollection(base.ResourceCollectionBase):
@property
def _resource_type(self):
return Manager
def __init__(self, connector, path, redfish_version=None):
"""A class representing a Manager Collection
:param connector: A Connector instance
:param path: The canonical path to the chassis collection resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(ManagerCollection, self).__init__(connector,
path,
redfish_version)

10
rsd_lib/resources/v2_2/telemetry/metric.py
View File

@ -100,13 +100,3 @@ class Metric(base.ResourceBase):
status = rsd_lib_common.StatusField('Status')
"""The report definition status"""
def __init__(self, connector, identity, redfish_version=None):
"""A class representing a Metric
:param connector: A Connector instance
:param identity: The identity of the Metric resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(Metric, self).__init__(connector, identity, redfish_version)

12
rsd_lib/resources/v2_2/telemetry/metric_report.py
View File

@ -88,15 +88,3 @@ class MetricReportCollection(base.ResourceCollectionBase):
@property
def _resource_type(self):
return MetricReport
def __init__(self, connector, path, redfish_version=None):
"""A class representing a MetricReportCollection
:param connector: A Connector instance
:param path: The canonical path to the Metric Report collection
resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(MetricReportCollection, self).__init__(connector, path,
redfish_version)

23
rsd_lib/resources/v2_2/telemetry/metric_report_definition.py
View File

@ -97,17 +97,6 @@ class MetricReportDefinition(base.ResourceBase):
metric_properties = base.Field("MetricProperties")
"""The report definition metric properties"""
def __init__(self, connector, identity, redfish_version=None):
"""A class representing a MetricReportDefinition
:param connector: A Connector instance
:param identity: The identity of the MetricReportDefinition resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(MetricReportDefinition, self).__init__(
connector, identity, redfish_version)
def _get_metrics_path(self):
"""Helper function to find the metrics path"""
if 'Metrics' not in self.json:
@ -155,18 +144,6 @@ class MetricReportDefinitionCollection(base.ResourceCollectionBase):
def _resource_type(self):
return MetricReportDefinition
def __init__(self, connector, path, redfish_version=None):
"""A class representing a ReportDefinitionCollection
:param connector: A Connector instance
:param path: The canonical path to the ReportDefinition collection
resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(MetricReportDefinitionCollection, self).__init__(
connector, path, redfish_version)
def create_metric_report_definition(self, metric_report_definition_req):
"""Create a new report definition

12
rsd_lib/resources/v2_2/telemetry/trigger.py
View File

@ -121,18 +121,6 @@ class TriggerCollection(base.ResourceCollectionBase):
def _resource_type(self):
return Trigger
def __init__(self, connector, path, redfish_version=None):
"""A class representing a TriggerCollection
:param connector: A Connector instance
:param path: The canonical path to the Trigger collection
resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(TriggerCollection, self).__init__(
connector, path, redfish_version)
def create_trigger(self, name=None, description=None, metric_type=None,
trigger_actions=None, numeric_triggers=None,
discrete_trigger_condition=None, discrete_triggers=None,

11
rsd_lib/resources/v2_2/update_service/action_info.py
View File

@ -28,17 +28,6 @@ class ActionInfo(base.ResourceBase):
oem = base.Field("Oem")
"""The action info oem"""
def __init__(self, connector, identity, redfish_version=None):
"""A class representing a ActionInfo
:param connector: A Connector instance
:param identity: The identity of the ActionInfo resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(ActionInfo, self).__init__(
connector, identity, redfish_version)
@property
@utils.cache_it
def parameters(self):

11
rsd_lib/resources/v2_2/update_service/update_service.py
View File

@ -55,17 +55,6 @@ class UpdateService(base.ResourceBase):
odata_context = base.Field("@odata.context")
"""The update service odata context"""
def __init__(self, connector, identity, redfish_version=None):
"""A class representing a UpdateService
:param connector: A Connector instance
:param identity: The identity of the UpdateService resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(UpdateService, self).__init__(connector, identity,
redfish_version)
def _get_action_info_path(self):
"""Helper function to find the ActionInfo path"""
return self.json.get("Actions").get("#UpdateService.SimpleUpdate").get(

13
rsd_lib/resources/v2_3/ethernet_switch/ethernet_switch.py
View File

@ -102,16 +102,3 @@ class EthernetSwitchCollection(base.ResourceCollectionBase):
@property
def _resource_type(self):
return EthernetSwitch
def __init__(self, connector, path, redfish_version=None):
"""A class representing a EthernetSwitch Collection
:param connector: A Connector instance
:param path: The canonical path to the EthernetSwitch collection
resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(EthernetSwitchCollection, self).__init__(connector,
path,
redfish_version)

22
rsd_lib/resources/v2_3/fabric/endpoint.py
View File

@ -96,17 +96,6 @@ class Endpoint(base.ResourceBase):
oem = OemField('Oem')
"""The OEM additional info of this endpoint"""
def __init__(self, connector, identity, redfish_version=None):
"""A class representing an Endpoint
:param connector: A Connector instance
:param identity: The identity of the RemoteTarget resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(Endpoint, self).__init__(connector, identity,
redfish_version)
def update_authentication(self, username=None, password=None):
"""Update endpoint authentication
@ -147,17 +136,6 @@ class EndpointCollection(base.ResourceCollectionBase):
def _resource_type(self):
return Endpoint
def __init__(self, connector, path, redfish_version=None):
"""A class representing an Endpoint
:param connector: A Connector instance
:param path: The canonical path to the Endpoint collection resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(EndpointCollection, self).__init__(connector, path,
redfish_version)
def _create_endpoint_request(self, identifiers, connected_entities,
protocol=None, ip_transport_details=None,
interface=None, authentication=None):

23
rsd_lib/resources/v2_3/fabric/fabric.py
View File

@ -44,17 +44,6 @@ class Fabric(base.ResourceBase):
status = rsd_lib_common.StatusField('Status')
def __init__(self, connector, identity, redfish_version=None):
"""A class representing a Fabric
:param connector: A Connector instance
:param identity: The identity of the Fabric resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(Fabric, self).__init__(connector, identity,
redfish_version)
def _get_endpoint_collection_path(self):
"""Helper function to find the EndpointCollection path"""
return utils.get_sub_resource_path_by(self, 'Endpoints')
@ -93,15 +82,3 @@ class FabricCollection(base.ResourceCollectionBase):
@property
def _resource_type(self):
return Fabric
def __init__(self, connector, path, redfish_version=None):
"""A class representing a FabricCollection
:param connector: A Connector instance
:param path: The canonical path to the Fabric collection
resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(FabricCollection, self).__init__(connector, path,
redfish_version)

11
rsd_lib/resources/v2_3/fabric/zone.py
View File

@ -46,17 +46,6 @@ class ZoneCollection(v2_1_zone.ZoneCollection):
def _resource_type(self):
return Zone
def __init__(self, connector, path, redfish_version=None):
"""A class representing a Zone Collection
:param connector: A Connector instance
:param path: The canonical path to the Zone collection resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(ZoneCollection, self).__init__(connector, path,
redfish_version)
def create_zone(self, endpoints):
"""Create a new Zone

11
rsd_lib/resources/v2_3/node/attach_action_info.py
View File

@ -40,17 +40,6 @@ class AttachResourceActionInfo(base.ResourceBase):
name = base.Field('Name')
"""The storage pool name string"""
def __init__(self, connector, identity, redfish_version=None):
"""A class representing a LogicalDrive
:param connector: A Connector instance
:param identity: The identity of the AttachResourceActionInfo resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(AttachResourceActionInfo, self).__init__(
connector, identity, redfish_version)
@property
@utils.cache_it
def parameters(self):

11
rsd_lib/resources/v2_3/node/node.py
View File

@ -185,17 +185,6 @@ class NodeCollection(v2_2_node.NodeCollection):
def _resource_type(self):
return Node
def __init__(self, connector, path, redfish_version=None):
"""A class representing a NodeCollection
:param connector: A Connector instance
:param path: The canonical path to the Node collection
resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(NodeCollection, self).__init__(connector, path, redfish_version)
def _create_compose_request(self, name=None, description=None,
processor_req=None, memory_req=None,
remote_drive_req=None, local_drive_req=None,

21
rsd_lib/resources/v2_3/storage_service/drive.py
View File

@ -133,16 +133,6 @@ class Drive(base.ResourceBase):
links = LinksField('Links')
"""These links to related components of this volume"""
def __init__(self, connector, identity, redfish_version=None):
"""A class representing a Volume
:param connector: A Connector instance
:param identity: The identity of the Volume resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(Drive, self).__init__(connector, identity, redfish_version)
def _get_metrics_path(self):
"""Helper function to find the Metrics path"""
return utils.get_sub_resource_path_by(self,
@ -169,14 +159,3 @@ class DriveCollection(base.ResourceCollectionBase):
@property
def _resource_type(self):
return Drive
def __init__(self, connector, path, redfish_version=None):
"""A class representing a DriveCollection
:param connector: A Connector instance
:param path: The canonical path to the Drive collection resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(DriveCollection, self).__init__(connector, path,
redfish_version)

21
rsd_lib/resources/v2_3/storage_service/storage_pool.py
View File

@ -71,16 +71,6 @@ class StoragePool(base.ResourceBase):
identifier = IdentifierField('Identifier')
"""These identifiers list of this volume"""
def __init__(self, connector, identity, redfish_version=None):
"""A class representing a LogicalDrive
:param connector: A Connector instance
:param identity: The identity of the LogicalDrive resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(StoragePool, self).__init__(connector, identity, redfish_version)
def _get_allocated_volumes_path(self):
"""Helper function to find the AllocatedVolumes path"""
return utils.get_sub_resource_path_by(self, 'AllocatedVolumes')
@ -119,14 +109,3 @@ class StoragePoolCollection(base.ResourceCollectionBase):
@property
def _resource_type(self):
return StoragePool
def __init__(self, connector, path, redfish_version=None):
"""A class representing a StoragePoolCollection
:param connector: A Connector instance
:param path: The canonical path to the StoragePool collection resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(StoragePoolCollection, self).__init__(connector, path,
redfish_version)

23
rsd_lib/resources/v2_3/storage_service/storage_service.py
View File

@ -41,17 +41,6 @@ class StorageService(base.ResourceBase):
status = rsd_lib_common.StatusField('Status')
"""The storage service status"""
def __init__(self, connector, identity, redfish_version=None):
"""A class representing a StorageService
:param connector: A Connector instance
:param identity: The identity of the StorageService resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(StorageService, self).__init__(connector, identity,
redfish_version)
def _get_volume_collection_path(self):
"""Helper function to find the VolumeCollection path"""
return utils.get_sub_resource_path_by(self, 'Volumes')
@ -122,15 +111,3 @@ class StorageServiceCollection(base.ResourceCollectionBase):
@property
def _resource_type(self):
return StorageService
def __init__(self, connector, path, redfish_version=None):
"""A class representing a StorageServiceCollection
:param connector: A Connector instance
:param path: The canonical path to the StorageService collection
resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(StorageServiceCollection, self).__init__(connector, path,
redfish_version)

21
rsd_lib/resources/v2_3/storage_service/volume.py
View File

@ -122,16 +122,6 @@ class Volume(base.ResourceBase):
_actions = VolumeActionsField('Actions', required=True)
def __init__(self, connector, identity, redfish_version=None):
"""A class representing a Volume
:param connector: A Connector instance
:param identity: The identity of the Volume resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(Volume, self).__init__(connector, identity, redfish_version)
def update(self, bootable=None, erased=None):
"""Update volume properties
@ -217,17 +207,6 @@ class VolumeCollection(base.ResourceCollectionBase):
def _resource_type(self):
return Volume
def __init__(self, connector, path, redfish_version=None):
"""A class representing a VolumeCollection
:param connector: A Connector instance
:param path: The canonical path to the Volume collection resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(VolumeCollection, self).__init__(connector, path,
redfish_version)
def _create_volume_request(self, capacity, access_capabilities=None,
capacity_sources=None, replica_infos=None,
bootable=None):

14
rsd_lib/resources/v2_3/system/ethernet_interface.py
View File

@ -74,17 +74,3 @@ class EthernetInterfaceCollection(ethernet_interface.
@property
def _resource_type(self):
return EthernetInterface
def __init__(self, connector, path, redfish_version=None):
"""A class representing a EthernetInterface Collection
:param connector: A Connector instance
:param path: The canonical path to the EthernetInterface collection
resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(EthernetInterfaceCollection, self).__init__(connector,
path,
redfish_version)

22
rsd_lib/resources/v2_4/fabric/endpoint.py
View File

@ -135,17 +135,6 @@ class Endpoint(base.ResourceBase):
oem = OemField('Oem')
"""The OEM additional info of this endpoint"""
def __init__(self, connector, identity, redfish_version=None):
"""A class representing an Endpoint
:param connector: A Connector instance
:param identity: The identity of the RemoteTarget resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(Endpoint, self).__init__(connector, identity,
redfish_version)
def delete(self):
"""Delete this endpoint"""
self._conn.delete(self.path)
@ -157,17 +146,6 @@ class EndpointCollection(base.ResourceCollectionBase):
def _resource_type(self):
return Endpoint
def __init__(self, connector, path, redfish_version=None):
"""A class representing an Endpoint
:param connector: A Connector instance
:param path: The canonical path to the Endpoint collection resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(EndpointCollection, self).__init__(connector, path,
redfish_version)
def _create_endpoint_request(self, connected_entities, identifiers=None,
protocol=None, pci_id=None,
host_reservation_memory_bytes=None,

12
rsd_lib/resources/v2_4/fabric/fabric.py
View File

@ -44,15 +44,3 @@ class FabricCollection(base.ResourceCollectionBase):
@property
def _resource_type(self):
return Fabric
def __init__(self, connector, path, redfish_version=None):
"""A class representing a FabricCollection
:param connector: A Connector instance
:param path: The canonical path to the Fabric collection
resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(FabricCollection, self).__init__(connector, path,
redfish_version)

11
rsd_lib/resources/v2_4/node/node.py
View File

@ -100,17 +100,6 @@ class NodeCollection(node.NodeCollection):
def _resource_type(self):
return Node
def __init__(self, connector, path, redfish_version=None):
"""A class representing a NodeCollection
:param connector: A Connector instance
:param path: The canonical path to the Node collection
resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(NodeCollection, self).__init__(connector, path, redfish_version)
def _create_compose_request(self, name=None, description=None,
processor_req=None, memory_req=None,
remote_drive_req=None, local_drive_req=None,

12
rsd_lib/resources/v2_4/storage_service/storage_service.py
View File

@ -40,15 +40,3 @@ class StorageServiceCollection(base.ResourceCollectionBase):
@property
def _resource_type(self):
return StorageService
def __init__(self, connector, path, redfish_version=None):
"""A class representing a StorageServiceCollection
:param connector: A Connector instance
:param path: The canonical path to the StorageService collection
resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(StorageServiceCollection, self).__init__(connector, path,
redfish_version)

11
rsd_lib/resources/v2_4/storage_service/volume.py
View File

@ -44,14 +44,3 @@ class VolumeCollection(volume.VolumeCollection):
@property
def _resource_type(self):
return Volume
def __init__(self, connector, path, redfish_version=None):
"""A class representing a VolumeCollection
:param connector: A Connector instance
:param path: The canonical path to the Volume collection resource
:param redfish_version: The version of RedFish. Used to construct
the object according to schema of the given version.
"""
super(VolumeCollection, self).__init__(connector, path,
redfish_version)