From 849ce56a1657c3c66dcd595baa0adcd1235a1d1e Mon Sep 17 00:00:00 2001 From: "sonu.kumar" Date: Wed, 25 Nov 2015 16:12:55 +0530 Subject: [PATCH] Improve logging in designateclient We should delegate (when possible) formatting to the logger in order to perform formatting only when needed, by using: LOG.(message, data) instead of: LOG.(message % data) This change corrects some incorrect indentations in logs Change-Id: Ida8ab2958563f0752f20490f033922a60c1c1c01 --- designateclient/v2/cli/reverse.py | 2 +- designateclient/v2/cli/zones.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/designateclient/v2/cli/reverse.py b/designateclient/v2/cli/reverse.py index d4a83f2..eefdff4 100644 --- a/designateclient/v2/cli/reverse.py +++ b/designateclient/v2/cli/reverse.py @@ -118,4 +118,4 @@ class UnsetFloatingIPCommand(command.Command): def take_action(self, parsed_args): client = self.app.client_manager.dns client.floatingips.unset(parsed_args.floatingip_id) - LOG.info('FloatingIP PTR %s was unset' % parsed_args.floatingip_id) + LOG.info('FloatingIP PTR %s was unset', parsed_args.floatingip_id) diff --git a/designateclient/v2/cli/zones.py b/designateclient/v2/cli/zones.py index 20d347c..17c1076 100644 --- a/designateclient/v2/cli/zones.py +++ b/designateclient/v2/cli/zones.py @@ -250,7 +250,7 @@ class AbandonZoneCommand(command.Command): client.zones.abandon(parsed_args.id) - LOG.info("Z %(zone_id)s abandoned" % + LOG.info("Z %(zone_id)s abandoned", {"zone_id": parsed_args.id}) @@ -268,7 +268,7 @@ class AXFRZoneCommand(command.Command): client.zones.axfr(parsed_args.id) - LOG.info("Scheduled AXFR for zone %(zone_id)s" % + LOG.info("Scheduled AXFR for zone %(zone_id)s", {"zone_id": parsed_args.id}) @@ -376,7 +376,7 @@ class DeleteTransferRequestCommand(command.Command): client.zone_transfers.delete_request(parsed_args.id) - LOG.info('Zone Transfer %s was deleted' % parsed_args.id) + LOG.info('Zone Transfer %s was deleted', parsed_args.id) class AcceptTransferRequestCommand(command.Command):