From 3d8da9619f7f57daf5e5910c2738e80fc6c9a49d Mon Sep 17 00:00:00 2001
From: liusheng <liusheng@huawei.com>
Date: Wed, 4 Jan 2017 10:16:53 +0800
Subject: [PATCH] Remove the --long parameter when listing flavors

Because:
  - We only have one API to listing flavors
  - the OSC CLI support -c parameter that allow users to pick the return
    the fields what they want.

Change-Id: I5e1f3c7c5c10800a93d9004ea950305bfbf5db61
---
 moganclient/osc/v1/flavor.py                 | 46 ++++++--------------
 moganclient/tests/unit/osc/v1/test_flavor.py | 26 -----------
 2 files changed, 14 insertions(+), 58 deletions(-)

diff --git a/moganclient/osc/v1/flavor.py b/moganclient/osc/v1/flavor.py
index 061603a..34f18fa 100644
--- a/moganclient/osc/v1/flavor.py
+++ b/moganclient/osc/v1/flavor.py
@@ -128,43 +128,25 @@ class DeleteFlavor(command.Command):
 class ListFlavor(command.Lister):
     """List all baremetal flavors"""
 
-    def get_parser(self, prog_name):
-        parser = super(ListFlavor, self).get_parser(prog_name)
-        parser.add_argument(
-            '--long',
-            action='store_true',
-            default=False,
-            help=_("List additional fields in output")
-        )
-        return parser
-
     def take_action(self, parsed_args):
         bc_client = self.app.client_manager.baremetal_compute
 
         data = bc_client.flavor.list()
 
-        if parsed_args.long:
-            # This is the easiest way to change column headers
-            column_headers = (
-                "UUID",
-                "Name",
-                "Is Public",
-                "Description",
-                "Properties",
-            )
-            columns = (
-                "UUID",
-                "Name",
-                "Is Public",
-                "Description",
-                "Extra Specs",
-            )
-        else:
-            column_headers = columns = (
-                "UUID",
-                "Name",
-                "Is Public",
-            )
+        column_headers = (
+            "UUID",
+            "Name",
+            "Is Public",
+            "Description",
+            "Properties",
+        )
+        columns = (
+            "UUID",
+            "Name",
+            "Is Public",
+            "Description",
+            "Extra Specs",
+        )
 
         return (column_headers,
                 (utils.get_item_properties(
diff --git a/moganclient/tests/unit/osc/v1/test_flavor.py b/moganclient/tests/unit/osc/v1/test_flavor.py
index 9c9477e..1259c40 100644
--- a/moganclient/tests/unit/osc/v1/test_flavor.py
+++ b/moganclient/tests/unit/osc/v1/test_flavor.py
@@ -219,23 +219,11 @@ class TestFlavorList(TestFlavor):
         "UUID",
         "Name",
         "Is Public",
-    )
-
-    list_columns_long = (
-        "UUID",
-        "Name",
-        "Is Public",
         "Description",
         "Properties",
     )
 
     list_data = ((
-        TestFlavor.fake_flavor.uuid,
-        TestFlavor.fake_flavor.name,
-        TestFlavor.fake_flavor.is_public,
-        ),)
-
-    list_data_long = ((
         TestFlavor.fake_flavor.uuid,
         TestFlavor.fake_flavor.name,
         TestFlavor.fake_flavor.is_public,
@@ -257,20 +245,6 @@ class TestFlavorList(TestFlavor):
         self.assertEqual(self.list_columns, columns)
         self.assertEqual(self.list_data, tuple(data))
 
-    def test_flavor_list_with_long(self, mock_list):
-        arglist = [
-            '--long',
-        ]
-        verifylist = [
-            ('long', True),
-        ]
-        mock_list.return_value = [self.fake_flavor]
-        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
-        columns, data = self.cmd.take_action(parsed_args)
-        mock_list.assert_called_once_with('/types', response_key='types')
-        self.assertEqual(self.list_columns_long, columns)
-        self.assertEqual(self.list_data_long, tuple(data))
-
 
 @mock.patch.object(utils, 'find_resource')
 @mock.patch.object(flavor_mgr.FlavorManager, '_delete')