x/python-glareclient
Code Issues Proposed changes

Rename 'active' method to 'activate'

Browse Source 
Change-Id: Ic026a6059fc296243e63339bb6b9070af5c04ff2
This commit is contained in:
Mike Fedosin 2016-09-26 15:31:56 +03:00
parent 0a9d7b5b30
commit 3b6cc7eee7
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
glareclient/osc/v1/artifacts.py
View File

@ -261,8 +261,8 @@ class ActivateArtifact(command.ShowOne):
def take_action(self, parsed_args):
LOG.debug('take_action({0})'.format(parsed_args))
client = self.app.client_manager.artifact
data = client.artifacts.active(parsed_args.id,
type_name=parsed_args.type_name)
data = client.artifacts.activate(
parsed_args.id, type_name=parsed_args.type_name)
return self.dict2columns(data)

2
glareclient/tests/unit/osc/v1/fakes.py
View File

@ -73,7 +73,7 @@ class TestArtifacts(utils.TestCommand):
self.app.client_manager.artifact.artifacts.create = mock_g_servs
self.app.client_manager.artifact.artifacts.update = mock_g_servs
self.app.client_manager.artifact.artifacts.delete = mock_g_servs
self.app.client_manager.artifact.artifacts.active = mock_g_servs
self.app.client_manager.artifact.artifacts.activate = mock_g_servs
self.app.client_manager.artifact.artifacts.deactivate = mock_g_servs
self.app.client_manager.artifact.artifacts.reactivate = mock_g_servs
self.app.client_manager.artifact.artifacts.publish = mock_g_servs

4
glareclient/tests/unit/v1/test_artifacts.py
View File

@ -192,8 +192,8 @@ class TestController(testtools.TestCase):
def test_active_artifact(self):
art_id = '3a4560a1-e585-443e-9b39-553b46ec92a3'
self.controller.active(artifact_id=art_id,
type_name='sample_artifact')
self.controller.activate(artifact_id=art_id,
type_name='sample_artifact')
exp_headers = {
'Content-Type': 'application/json-patch+json'
}

2
glareclient/v1/artifacts.py
View File

@ -153,7 +153,7 @@ class Controller(object):
for artifact in paginate(url, page_size, limit):
yield artifact
def active(self, artifact_id, type_name=None):
def activate(self, artifact_id, type_name=None):
"""Set artifact status to 'active'.
:param artifact_id: ID of the artifact to get.