Bindep is a binary automation tool used in openstack-infra. With it,
projects can better control the default packages installed into the
OS. Because we are using puppet, we actually don't want any packages
installed by default as to better test our manifests.
Change-Id: I6dd27d73c32f8930b327df28b85e7ff7a595fc30
Co-Authored-By: Paul Belanger <pabelanger@redhat.com>
mock is not used anywhere in the module, let's drop it.
This patch will help to hit this bug:
https://launchpad.net/bugs/1492636
Change-Id: Id8a2ab10329c05af5b766e2a441a744ced073671
Clean-up the code for Rakefile & spec_helper_acceptance by using the
puppet-openstack_spec_helper library.
Change-Id: Ic75bfdd4cbb2a92446b608f3fdef712ac1adbaba
This change adds the rspec-puppet-facts gem to the spec helper so that
we can centralize the management of the base operating systems that we
support. rspec-puppet-facts allows us to simplify our unit tests and
provides a more complete list of Operating Systems and their associated
facts for the unit tests. With this change we can now loop over and
test CentOS, Debian, Fedora, RedHat, and Ubuntu by simply providing a
list of supported os to rspec-puppet-facts.
Additionally this change includes a central object for managing our
supported os list for rspec-puppet-facts and providing our default facts
like os_service_default. This central object should replace the usage of
@default_facts within the unit tests for each module.
Change-Id: I561ea844c05481a804975e77ff5f45002449f9a5
This commit will add code to spec_helper.rb to create the
os_service_default fact before all rspec-puppet tests.
This is needed so that the $::os_service_default pattern is testable
and we don't overwrite changes to modules that have been converted by
hand.
Change-Id: I657e9b550e45dfbcf0bf54d94a1a12ef6f3b03db
- Why? because we disable a check which has been deleted for a
while from puppet-lint code!
Change-Id: I0a01bc41ef15d0312520cfaf71cb704843cbe824
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
* install r10k gem
* add openstack/ to .gitignore
* Update Rakefile to not use fixtures anymore
See https://review.openstack.org/#/c/226830/ for background.
Change-Id: I4513491b4f53c74acd433c0045c5f3c956bc06ce
Adding missing remote_branch and pre_commit_script parameters in the
default modulesync.yml. This is necessary for the post-merge hook[1] to
work.
[1] https://review.openstack.org/#/c/189216/
Change-Id: I5203e3c7b84c808bef61542efd2c4d973729b425
A sample is already specified if someone wants to run msync from its
computer, but the goal here is that a commit into this repo will
automatically update all the repo in managed_modules.yml.
For that reason we provide a default modulesync.yml that will be used by
a hook in openstack-infra to sync the change across all the modules
Change-Id: Ia140d0b7bc669e0fc2caf073ab1f2798b6958f55
Since Colleen patchs, we now uses beaker_zuul_cloner across
all modules for acceptances tests, this file doesn't contain
specifics settings.
https://review.openstack.org/#/q/topic:beaker_zuul_cloner,n,z
Change-Id: I90d9c63da9732dde6cffd0292b694455a388d733
Separate nodepool files to have trusty & centos7 support
in OpenStack infra.
Fix default definition and centos/trusy defs using Colleen
trusty changes on https://review.openstack.org/#/c/182080
Change-Id: Idc677c214b1ea431b96f18ab6f1d3e0de7e76585
This commit modifies our default config to include rspec-puppet 2.2.0
from 2.1.0. This is to address the issue with helper code not being
loaded properly, fixed by
d4278834d5.
Change-Id: I1ef9a7c55aff05fb94da16884d04e922d2c99486
Add default config for Gemfile, puppet-lint disabled checks,
nodepool files for centos7 and trusty, and a sample
modulesync.yaml for configuring msync.
Co-Authored-By: Cody Herries <cody@puppetlabs.com>
Change-Id: Ib00a5b3b9c62f063b0b88b2d883e0ebad6506840
This checks which Puppet resources have been explicitly checked as part
of the current test run and outputs both a coverage percentage and a
list of untouched resources.
Change-Id: Idef8ed412e3fe5e15691cc60b1ef04104967ee0a
An effort to provide beaker tests for the different puppet modules has
been started. The first module to implement test is puppet-glance[1].
Following this review we set the different nodesets file here so they
can be shared amongst all the modules.
[1] https://review.openstack.org/#/c/174659/
Change-Id: I9a2296bdc6824e8a27e3dd223cab9d40202ea8f5
Ignore module/ (cloned modules location), modulesync.yml because this
file is user specific, vi swap files, and Gemfile.lock
Change-Id: I8048a29f3958bfd541b81bbca8456603a10bb373
