x/puppet-midonet
Code Issues Proposed changes

Add client_ip at zookeeper config

Browse Source 
Let the DevOps choose the IP from where to listen ZooKeeper client
requests.

Change-Id: I35c1ed56ea0ba417d9a50539760bc553026d27cd
This commit is contained in:
Jaume Devesa 2015-07-22 12:17:17 +02:00
parent e58177f3c6
commit 31058e7887
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
manifests/zookeeper.pp
View File

@ -8,6 +8,8 @@
# Full list of ZooKeeper servers that run in the same cluster.
# [*server_id*]
# Identifier of this ZooKeeper server in the cluster.
# [*client_ip*]
# IP address from where the ZooKeeper listen client requests
#
# === Examples
#
@ -90,11 +92,12 @@
# limitations under the License.
#
class midonet::zookeeper($servers, $server_id) {
class midonet::zookeeper($servers, $server_id, $client_ip=$::ipaddress_eth0) {
class {'::zookeeper':
servers => zookeeper_servers($servers),
id => $server_id,
cfg_dir => '/etc/zookeeper'
servers => zookeeper_servers($servers),
id => $server_id,
cfg_dir => '/etc/zookeeper',
client_ip => $client_ip
}
}

5
spec/classes/midonet_zookeeper_spec.rb
View File

@ -22,8 +22,9 @@ describe 'midonet::zookeeper' do
it 'should call deric/zookeeper properly' do
is_expected.to contain_class('zookeeper').with({
'servers' => zookeeper_params[:servers],
'id' => zookeeper_params[:id]
'servers' => zookeeper_params[:servers],
'id' => zookeeper_params[:id],
'client_ip' => '127.0.0.1'
})
end
end