x/driverlog
Code Issues Proposed changes

Use assertIn in unittests

Browse Source 
Replace usage of assertTrue(A in B) with assertIn(A, B). This is
required for the pep8 pipeline to pass.

Change-Id: If0af443590ea2062ab04801ea27f7db0b17e8a04
This commit is contained in:
Moritz "WanzenBug" Wanzenböck 2021-03-10 13:59:38 +01:00
parent bd35744639
commit ec0843e19e
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
driverlog/tests/unit/test_config_files.py
View File

@ -104,16 +104,16 @@ class TestConfigFiles(testtools.TestCase):
for driver in dd['drivers']:
for release_id in (driver.get('releases') or []):
self.assertTrue(release_id in release_ids,
'Wrong release id: %s' % release_id)
self.assertIn(release_id, release_ids,
'Wrong release id: %s' % release_id)
def test_project_reference_validity(self):
dd = self._read_file('etc/default_data.json')
project_ids = set([p['id'] for p in dd['projects']])
for driver in dd['drivers']:
self.assertTrue(driver['project_id'] in project_ids,
'Wrong project id: %s' % driver['project_id'])
self.assertIn(driver['project_id'], project_ids,
'Wrong project id: %s' % driver['project_id'])
def test_default_data_duplicate_keys(self):
try:

6
driverlog/tests/unit/test_main.py
View File

@ -72,9 +72,9 @@ class TestMain(testtools.TestCase):
dd['drivers'].keys())
driver = dd['drivers'][
('openstack/neutron', 'Cisco', 'Cisco Nexus Plugin')]
self.assertTrue('grizzly' in driver['releases'],
'Grizzly should be copied from releases into '
'os_version_map')
self.assertIn('grizzly', driver['releases'],
'Grizzly should be copied from releases into '
'os_version_map')
def _make_test_memcached(self, storage=None):
storage = storage or {}