x/deb-oslo.versionedobjects
Code Issues Proposed changes

Fix to_json_schema() call

Browse Source 
The to_json_schema() method now has the 'required_fields' incorrectly
placed outside of the 'data_key' dict. This patch moves it inside that
dict.

Change-Id: Id50a75bc27198576b615c4e76c046a53008d20bc
Closes-Bug: #1608870
This commit is contained in:
tengqm 2016-08-02 05:32:29 -04:00
parent 67ba3a0840
commit 0146734e7e
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
oslo_versionedobjects/base.py
View File

@ -360,10 +360,10 @@ class VersionedObject(object):
data_key: { data_key: {
'type': 'object', 'type': 'object',
'description': 'fields of %s' % (obj_name), 'description': 'fields of %s' % (obj_name),
'properties': field_schemas 'properties': field_schemas,
},
'required': required_fields 'required': required_fields
}, },
},
'required': [namespace_key, name_key, version_key, data_key] 'required': [namespace_key, name_key, version_key, data_key]
} }
return schema return schema

2
oslo_versionedobjects/tests/test_objects.py
View File

@ -2094,8 +2094,8 @@ class TestSchemaGeneration(test.TestCase):
'foo': {'type': ['fake']}, 'foo': {'type': ['fake']},
'bar': {'type': ['fake', 'null']} 'bar': {'type': ['fake', 'null']}
}, },
'required': ['bar', 'foo'],
}, },
'required': ['bar', 'foo']
}, },
'required': ['versioned_object.namespace', 'versioned_object.name', 'required': ['versioned_object.namespace', 'versioned_object.name',
'versioned_object.version', 'versioned_object.data'] 'versioned_object.version', 'versioned_object.data']