x/deb-os-testr
Code Issues Proposed changes

Fix return code on test run failure

Browse Source 
This commit fixes the return code handling to ensure we return the
same return code as the called test runner.
This commit is contained in:
Matthew Treinish 2015-03-17 18:55:17 -04:00
parent 898dbbbda6
commit b914b96d4f
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
os_testr/os_testr.py
View File

@ -83,7 +83,8 @@ def call_testr(regex, subunit, pretty, list_tests, slowest):
ps.stdout.close()
else:
proc = subprocess.Popen(cmd, env=env)
return_code = proc.communicate()[0]
proc.communicate()
return_code = proc.returncode
if slowest and not list_tests:
print("\nSlowest Tests:\n")
slow_proc = subprocess.Popen(['testr', 'slowest'], env=env)
@ -101,14 +102,16 @@ def call_subunit_run(test_id, pretty):
ps.stdout.close()
else:
proc = subprocess.Popen(cmd, env=env)
return_code = proc.communicate()[0]
proc.communicate()
return_code = proc.returncode
return return_code
def call_testtools_run(test_id):
cmd = ['python', '-m', 'testtools.run', test_id]
env = copy.deepcopy(os.environ)
proc = subprocess.Popen(cmd, env=env)
return_code = proc.communicate()[0]
proc.communicate()
return_code = proc.returncode
return return_code
def main():