x/deb-os-client-config
Code Issues Proposed changes

Replace assertEqual(None, *) with assertIsNone in tests

Browse Source 
Replace assertEqual(None, *) with assertIsNone in tests to have
more clear messages in case of failure.

Change-Id: Ia1af9f64f4f0a66c1429d81313b2c27a7c67cdd7
Closes-bug: #1280522
This commit is contained in:
Shuquan Huang 2015-12-17 13:58:10 +08:00
parent 837ca71228
commit 88b7e643b9
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
os_client_config/tests/test_cloud_config.py
View File

@ -47,7 +47,7 @@ class TestCloudConfig(base.TestCase):
self.assertEqual(1, cc.a)
# Look up prefixed attribute, fail - returns None
self.assertEqual(None, cc.os_b)
self.assertIsNone(cc.os_b)
# Look up straight value, then prefixed value
self.assertEqual(3, cc.c)
@ -139,7 +139,7 @@ class TestCloudConfig(base.TestCase):
self.assertEqual('region-al', cc.get_region_name())
self.assertEqual('region-al', cc.get_region_name('image'))
self.assertEqual('region-bl', cc.get_region_name('compute'))
self.assertEqual(None, cc.get_api_version('image'))
self.assertIsNone(cc.get_api_version('image'))
self.assertEqual('2', cc.get_api_version('compute'))
self.assertEqual('mage', cc.get_service_type('image'))
self.assertEqual('compute', cc.get_service_type('compute'))
@ -149,7 +149,7 @@ class TestCloudConfig(base.TestCase):
cc.get_endpoint('compute'))
self.assertEqual(None,
cc.get_endpoint('image'))
self.assertEqual(None, cc.get_service_name('compute'))
self.assertIsNone(cc.get_service_name('compute'))
self.assertEqual('locks', cc.get_service_name('identity'))
def test_volume_override(self):