Cosmin Poieana b2c99ff910 Take care of return codes when executing scripts
As userdata plugin is doing when executing userdata scripts,
do the same for the scripts executed under the localscripts plugin.
    * move the `get_plugin_return_value` to a common place
    * properly test the method above
    * use it with the localscripts plugin and make sure to choose
      the most comprehensive plugin status and reboot requirement

Change-Id: Id3aeab079be39e2c4d3d8bf51ef10ef1c7be68e2
2015-06-27 16:19:38 +03:00

73 lines
2.8 KiB
Python

# Copyright 2014 Cloudbase Solutions Srl
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import os
import unittest
try:
import unittest.mock as mock
except ImportError:
import mock
from cloudbaseinit.plugins.common import base
from cloudbaseinit.plugins.common import localscripts
from cloudbaseinit.tests import testutils
class LocalScriptsPluginTests(unittest.TestCase):
def setUp(self):
self._localscripts = localscripts.LocalScriptsPlugin()
@mock.patch('os.listdir')
@mock.patch('os.path.isfile')
def test_get_files_in_dir(self, mock_isfile, mock_listdir):
fake_path = os.path.join('fake', 'path')
fake_file_list = ['second', 'first', 'third', 'last']
mock_isfile.return_value = True
mock_listdir.return_value = fake_file_list
response = self._localscripts._get_files_in_dir(fake_path)
mock_listdir.assert_called_once_with(fake_path)
self.assertEqual(
sorted(os.path.join(fake_path, f) for f in fake_file_list),
response)
@mock.patch('cloudbaseinit.plugins.common.execcmd'
'.get_plugin_return_value')
@testutils.ConfPatcher('local_scripts_path',
mock.sentinel.mock_local_scripts_path)
@mock.patch('cloudbaseinit.plugins.common.localscripts'
'.LocalScriptsPlugin._get_files_in_dir')
@mock.patch('cloudbaseinit.plugins.common.fileexecutils.exec_file')
def test_execute(self, mock_exec_file, mock_get_files_in_dir,
mock_get_plugin_return_value):
mock_service = mock.MagicMock()
fake_path = os.path.join('fake', 'path')
mock_get_files_in_dir.return_value = [fake_path] * 2
mock_exec_file.side_effect = [1001, 1002]
mock_get_plugin_return_value.side_effect = [
(base.PLUGIN_EXECUTE_ON_NEXT_BOOT, False),
(base.PLUGIN_EXECUTION_DONE, True),
]
response = self._localscripts.execute(mock_service, shared_data=None)
mock_get_files_in_dir.assert_called_once_with(
mock.sentinel.mock_local_scripts_path)
mock_exec_file.assert_called_with(fake_path)
mock_get_plugin_return_value.assert_any_call(1001)
mock_get_plugin_return_value.assert_any_call(1002)
self.assertEqual((base.PLUGIN_EXECUTE_ON_NEXT_BOOT, True), response)