Cosmin Poieana b2c99ff910 Take care of return codes when executing scripts
As userdata plugin is doing when executing userdata scripts,
do the same for the scripts executed under the localscripts plugin.
    * move the `get_plugin_return_value` to a common place
    * properly test the method above
    * use it with the localscripts plugin and make sure to choose
      the most comprehensive plugin status and reboot requirement

Change-Id: Id3aeab079be39e2c4d3d8bf51ef10ef1c7be68e2
2015-06-27 16:19:38 +03:00

54 lines
1.8 KiB
Python

# Copyright 2014 Cloudbase Solutions Srl
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import os
from oslo.config import cfg
from cloudbaseinit.plugins.common import base
from cloudbaseinit.plugins.common import execcmd
from cloudbaseinit.plugins.common import fileexecutils
opts = [
cfg.StrOpt('local_scripts_path', default=None,
help='Path location containing scripts to be executed when '
'the plugin runs'),
]
CONF = cfg.CONF
CONF.register_opts(opts)
class LocalScriptsPlugin(base.BasePlugin):
def _get_files_in_dir(self, path):
return sorted([os.path.join(path, f) for f in os.listdir(path)
if os.path.isfile(os.path.join(path, f))])
def execute(self, service, shared_data):
plugin_status = base.PLUGIN_EXECUTION_DONE
reboot = False
if CONF.local_scripts_path:
for file_path in self._get_files_in_dir(CONF.local_scripts_path):
ret_val = fileexecutils.exec_file(file_path)
new_plugin_status, new_reboot = \
execcmd.get_plugin_return_value(ret_val)
plugin_status = max(plugin_status, new_plugin_status)
reboot = reboot or new_reboot
if reboot:
break
return plugin_status, reboot