4d1d7a9bb5
1. Remove the usage of the path.join function now that all code should be going through the util file methods (and they can be mocked out as needed). 2. Adjust all occurences of the above join function to either not use it or replace it with the standard os.path.join (which can also be mocked out as needed) 3. Fix pylint from complaining about the tests folder 'helpers.py' not being found 4. Add a pylintrc file that is used instead of the options hidden in the 'run_pylint' tool.
202 lines
6.7 KiB
Python
202 lines
6.7 KiB
Python
from mocker import MockerTestCase
|
|
|
|
from cloudinit import cloud
|
|
from cloudinit import helpers
|
|
from cloudinit import util
|
|
|
|
from cloudinit.config import cc_ca_certs
|
|
|
|
import logging
|
|
|
|
|
|
class TestNoConfig(MockerTestCase):
|
|
def setUp(self):
|
|
super(TestNoConfig, self).setUp()
|
|
self.name = "ca-certs"
|
|
self.cloud_init = None
|
|
self.log = logging.getLogger("TestNoConfig")
|
|
self.args = []
|
|
|
|
def test_no_config(self):
|
|
"""
|
|
Test that nothing is done if no ca-certs configuration is provided.
|
|
"""
|
|
config = util.get_builtin_cfg()
|
|
self.mocker.replace(util.write_file, passthrough=False)
|
|
self.mocker.replace(cc_ca_certs.update_ca_certs, passthrough=False)
|
|
self.mocker.replay()
|
|
|
|
cc_ca_certs.handle(self.name, config, self.cloud_init, self.log,
|
|
self.args)
|
|
|
|
|
|
class TestConfig(MockerTestCase):
|
|
def setUp(self):
|
|
super(TestConfig, self).setUp()
|
|
self.name = "ca-certs"
|
|
self.paths = None
|
|
self.cloud = cloud.Cloud(None, self.paths, None, None, None)
|
|
self.log = logging.getLogger("TestNoConfig")
|
|
self.args = []
|
|
|
|
# Mock out the functions that actually modify the system
|
|
self.mock_add = self.mocker.replace(cc_ca_certs.add_ca_certs,
|
|
passthrough=False)
|
|
self.mock_update = self.mocker.replace(cc_ca_certs.update_ca_certs,
|
|
passthrough=False)
|
|
self.mock_remove = self.mocker.replace(
|
|
cc_ca_certs.remove_default_ca_certs, passthrough=False)
|
|
|
|
# Order must be correct
|
|
self.mocker.order()
|
|
|
|
def test_no_trusted_list(self):
|
|
"""
|
|
Test that no certificates are written if the 'trusted' key is not
|
|
present.
|
|
"""
|
|
config = {"ca-certs": {}}
|
|
|
|
# No functions should be called
|
|
self.mock_update()
|
|
self.mocker.replay()
|
|
|
|
cc_ca_certs.handle(self.name, config, self.cloud, self.log, self.args)
|
|
|
|
def test_empty_trusted_list(self):
|
|
"""Test that no certificate are written if 'trusted' list is empty."""
|
|
config = {"ca-certs": {"trusted": []}}
|
|
|
|
# No functions should be called
|
|
self.mock_update()
|
|
self.mocker.replay()
|
|
|
|
cc_ca_certs.handle(self.name, config, self.cloud, self.log, self.args)
|
|
|
|
def test_single_trusted(self):
|
|
"""Test that a single cert gets passed to add_ca_certs."""
|
|
config = {"ca-certs": {"trusted": ["CERT1"]}}
|
|
|
|
self.mock_add(["CERT1"])
|
|
self.mock_update()
|
|
self.mocker.replay()
|
|
|
|
cc_ca_certs.handle(self.name, config, self.cloud, self.log, self.args)
|
|
|
|
def test_multiple_trusted(self):
|
|
"""Test that multiple certs get passed to add_ca_certs."""
|
|
config = {"ca-certs": {"trusted": ["CERT1", "CERT2"]}}
|
|
|
|
self.mock_add(["CERT1", "CERT2"])
|
|
self.mock_update()
|
|
self.mocker.replay()
|
|
|
|
cc_ca_certs.handle(self.name, config, self.cloud, self.log, self.args)
|
|
|
|
def test_remove_default_ca_certs(self):
|
|
"""Test remove_defaults works as expected."""
|
|
config = {"ca-certs": {"remove-defaults": True}}
|
|
|
|
self.mock_remove()
|
|
self.mock_update()
|
|
self.mocker.replay()
|
|
|
|
cc_ca_certs.handle(self.name, config, self.cloud, self.log, self.args)
|
|
|
|
def test_no_remove_defaults_if_false(self):
|
|
"""Test remove_defaults is not called when config value is False."""
|
|
config = {"ca-certs": {"remove-defaults": False}}
|
|
|
|
self.mock_update()
|
|
self.mocker.replay()
|
|
|
|
cc_ca_certs.handle(self.name, config, self.cloud, self.log, self.args)
|
|
|
|
def test_correct_order_for_remove_then_add(self):
|
|
"""Test remove_defaults is not called when config value is False."""
|
|
config = {"ca-certs": {"remove-defaults": True, "trusted": ["CERT1"]}}
|
|
|
|
self.mock_remove()
|
|
self.mock_add(["CERT1"])
|
|
self.mock_update()
|
|
self.mocker.replay()
|
|
|
|
cc_ca_certs.handle(self.name, config, self.cloud, self.log, self.args)
|
|
|
|
|
|
class TestAddCaCerts(MockerTestCase):
|
|
|
|
def setUp(self):
|
|
super(TestAddCaCerts, self).setUp()
|
|
self.paths = helpers.Paths({
|
|
'cloud_dir': self.makeDir()
|
|
})
|
|
|
|
def test_no_certs_in_list(self):
|
|
"""Test that no certificate are written if not provided."""
|
|
self.mocker.replace(util.write_file, passthrough=False)
|
|
self.mocker.replay()
|
|
cc_ca_certs.add_ca_certs([])
|
|
|
|
def test_single_cert(self):
|
|
"""Test adding a single certificate to the trusted CAs."""
|
|
cert = "CERT1\nLINE2\nLINE3"
|
|
|
|
mock_write = self.mocker.replace(util.write_file, passthrough=False)
|
|
mock_write("/usr/share/ca-certificates/cloud-init-ca-certs.crt",
|
|
cert, mode=0644)
|
|
mock_write("/etc/ca-certificates.conf",
|
|
"\ncloud-init-ca-certs.crt", omode="ab")
|
|
self.mocker.replay()
|
|
|
|
cc_ca_certs.add_ca_certs([cert])
|
|
|
|
def test_multiple_certs(self):
|
|
"""Test adding multiple certificates to the trusted CAs."""
|
|
certs = ["CERT1\nLINE2\nLINE3", "CERT2\nLINE2\nLINE3"]
|
|
expected_cert_file = "\n".join(certs)
|
|
|
|
mock_write = self.mocker.replace(util.write_file, passthrough=False)
|
|
mock_write("/usr/share/ca-certificates/cloud-init-ca-certs.crt",
|
|
expected_cert_file, mode=0644)
|
|
mock_write("/etc/ca-certificates.conf",
|
|
"\ncloud-init-ca-certs.crt", omode="ab")
|
|
self.mocker.replay()
|
|
|
|
cc_ca_certs.add_ca_certs(certs)
|
|
|
|
|
|
class TestUpdateCaCerts(MockerTestCase):
|
|
def test_commands(self):
|
|
mock_check_call = self.mocker.replace(util.subp,
|
|
passthrough=False)
|
|
mock_check_call(["update-ca-certificates"], capture=False)
|
|
self.mocker.replay()
|
|
|
|
cc_ca_certs.update_ca_certs()
|
|
|
|
|
|
class TestRemoveDefaultCaCerts(MockerTestCase):
|
|
|
|
def setUp(self):
|
|
super(TestRemoveDefaultCaCerts, self).setUp()
|
|
self.paths = helpers.Paths({
|
|
'cloud_dir': self.makeDir()
|
|
})
|
|
|
|
def test_commands(self):
|
|
mock_delete_dir_contents = self.mocker.replace(
|
|
util.delete_dir_contents, passthrough=False)
|
|
mock_write = self.mocker.replace(util.write_file, passthrough=False)
|
|
mock_subp = self.mocker.replace(util.subp,
|
|
passthrough=False)
|
|
|
|
mock_delete_dir_contents("/usr/share/ca-certificates/")
|
|
mock_delete_dir_contents("/etc/ssl/certs/")
|
|
mock_write("/etc/ca-certificates.conf", "", mode=0644)
|
|
mock_subp(('debconf-set-selections', '-'),
|
|
"ca-certificates ca-certificates/trust_new_crts select no")
|
|
self.mocker.replay()
|
|
|
|
cc_ca_certs.remove_default_ca_certs()
|