x/broadview-lib
Code Issues Proposed changes

Change naming on some of the API functions for consistency

Browse Source 
Change-Id: I5937850a5b562e6ddb8741f2b8b9a6720da0dd83
This commit is contained in:
Volodymyr Samotiy 2016-07-11 14:42:10 +03:00
parent 45b62c5a34
commit 27c192c61e
4 changed files with 11 additions and 8 deletions

2
broadview_lib/pt/packet_trace_ecmp_resolution.py

@ -22,7 +22,7 @@ class PacketTraceECMPResolution():
def getPort(self): def getPort(self):
return self._port return self._port
def getECMPLINKResolution(self): def getECMPLinkResolution(self):
return self._ecmplinkresolution return self._ecmplinkresolution
def __repr__(self): def __repr__(self):

5
broadview_lib/pt/packet_trace_lag_resolution.py

@ -22,9 +22,12 @@ class PacketTraceLAGResolution():
def getPort(self): def getPort(self):
return self._port return self._port
def getLAGLINKResolution(self): def getLAGLinkResolution(self):
return self._laglinkresolution return self._laglinkresolution
def __repr__(self):
return "packet-trace-lag-resolution"
def parse(self, data, port=None): def parse(self, data, port=None):
if port == None: if port == None:
ret = False ret = False

4
broadview_lib/pt/packet_trace_profile.py

@ -28,10 +28,10 @@ class PacketTraceProfileEntry():
def getPort(self): def getPort(self):
return self._port return self._port
def getLAGLINKResolution(self): def getLAGLinkResolution(self):
return self._laglinkresolution return self._laglinkresolution
def getECMPLINKResolution(self): def getECMPLinkResolution(self):
return self._ecmplinkresolution return self._ecmplinkresolution
class PacketTraceProfile(): class PacketTraceProfile():

8
broadview_lib/pt/pt_parser.py

@ -1734,7 +1734,7 @@ class TestParser(unittest.TestCase):
val = rep.getPacketTraceLAGResolution() val = rep.getPacketTraceLAGResolution()
for m in val: for m in val:
llr = m.getLAGLINKResolution() llr = m.getLAGLinkResolution()
if m.getPort() == "1": if m.getPort() == "1":
self.assertEqual(llr.getLAGID(), "1") self.assertEqual(llr.getLAGID(), "1")
@ -1801,7 +1801,7 @@ class TestParser(unittest.TestCase):
val = rep.getPacketTraceECMPResolution() val = rep.getPacketTraceECMPResolution()
for m in val: for m in val:
llr = m.getECMPLINKResolution() llr = m.getECMPLinkResolution()
if m.getPort() == "1": if m.getPort() == "1":
for x in llr: for x in llr:
if x.getECMPGroupID() == "200256": if x.getECMPGroupID() == "200256":
@ -2124,7 +2124,7 @@ class TestParser(unittest.TestCase):
for m in n: for m in n:
realm = m.getRealm() realm = m.getRealm()
if realm == "lag-link-resolution": if realm == "lag-link-resolution":
llr = m.getLAGLINKResolution() llr = m.getLAGLinkResolution()
if m.getPort() == "1": if m.getPort() == "1":
self.assertEqual(llr.getLAGID(), "2") self.assertEqual(llr.getLAGID(), "2")
@ -2150,7 +2150,7 @@ class TestParser(unittest.TestCase):
else: else:
self.assertEqual("unexpected port {}".format(llr.getPort()), True) self.assertEqual("unexpected port {}".format(llr.getPort()), True)
elif realm == "ecmp-link-resolution": elif realm == "ecmp-link-resolution":
elr = m.getECMPLINKResolution() elr = m.getECMPLinkResolution()
if m.getPort() == "1": if m.getPort() == "1":
for x in elr: for x in elr: