x/broadview-collector
Code Issues Proposed changes

Catch possible exceptions in POST handler

Browse Source 
Change-Id: I870292ae519c0d2b1779504c7ed5461b5afe0d87
This commit is contained in:
Vitaliy Kharechko 2016-06-09 15:34:51 +03:00
parent 9fd350b18d
commit 96652a1b39
1 changed files with 24 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
broadview_collector/broadview_collector.py → broadview_collector.py
View File

@ -146,15 +146,30 @@ class HTTPRequestHandler(BaseHTTPRequestHandler):
pass pass
def do_POST(self): def do_POST(self):
ctype, pdict = cgi.parse_header(self.headers.getheader('content-type')) try:
length = int(self.headers.getheader('content-length')) ctype, pdict = cgi.parse_header(self.headers.getheader('content-type'))
data = ast.literal_eval(json.loads(self.rfile.read(length))) except:
code = collector.handlePOST(self.path, ctype, length, self.client_address[0], data ) e = sys.exc_info()[0]
data = json.dumps({}) LOG.info("broadview_collector: do_POST missing content-type {}".format(e))
self.send_response(code) ctype = None
self.send_header('Content-Type', 'application/json') try:
self.end_headers() length = int(self.headers.getheader('content-length'))
self.wfile.write(data) except:
e = sys.exc_info()[0]
LOG.info("broadview_collector: do_POST missing content-length {}".format(e))
length = 0
if ctype and "json" in ctype.lower():
data = ast.literal_eval(json.loads(self.rfile.read(length)))
code = collector.handlePOST(self.path, ctype, length, self.client_address[0], data )
data = json.dumps({})
try:
self.send_response(code)
self.send_header('Content-Type', 'application/json')
self.end_headers()
self.wfile.write(data)
except:
e = sys.exc_info()[0]
LOG.info("broadview_collector: do_POST unable to write response {}".format(e))
return return