x/alexandria
Code Issues Proposed changes

Rename _push functions into set (for coherency with get)

Browse Source
This commit is contained in:
Bruno Cornec 2015-12-23 12:08:44 +01:00
parent 12b04cf251
commit e1d6e5afd3
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
alexandria/app.py
View File

@ -94,7 +94,7 @@ def synchronize_ci(ci):
# Push the data provided above to all our drivers # Push the data provided above to all our drivers
for driver in config.alexandria.drivers: for driver in config.alexandria.drivers:
app.logger.info("Push information to {} driver.".format(driver.get_driver_type())) app.logger.info("Push information to {} driver.".format(driver.get_driver_type()))
driver.push_ci(ci) driver.set_ci(ci)
@app.route('/ci', methods=['PUT']) @app.route('/ci', methods=['PUT'])
@ -162,4 +162,3 @@ if __name__ == "__main__":
#pp.pprint(models.Manager) # debugging example. #pp.pprint(models.Manager) # debugging example.
app.logger.info("Starting %s...", config.alexandria.NAME) app.logger.info("Starting %s...", config.alexandria.NAME)
app.run(port=int(config.alexandria.conf_file.get_alexandria_port())) app.run(port=int(config.alexandria.conf_file.get_alexandria_port()))

9
alexandria/drivers.py
View File

@ -20,7 +20,7 @@ class Driver(object):
def get_ci(self, ci): def get_ci(self, ci):
pass pass
def push_ci(self, ci): def set_ci(self, ci):
pass pass
@ -30,7 +30,7 @@ class Itop(Driver):
print("Get from itop") print("Get from itop")
return True return True
def push_ci(self, ci): def set_ci(self, ci):
username = config.alexandria.conf_file.get_driver_parameters("itop", "loginItop") username = config.alexandria.conf_file.get_driver_parameters("itop", "loginItop")
password = config.alexandria.conf_file.get_driver_parameters("itop", "passwordItop") password = config.alexandria.conf_file.get_driver_parameters("itop", "passwordItop")
config.logger.debug("login : {}, password : {}".format( config.logger.debug("login : {}, password : {}".format(
@ -87,6 +87,9 @@ class Redfish(Driver):
#print("Redfish API version : {} \n".format(remote_mgmt.get_api_version())) #print("Redfish API version : {} \n".format(remote_mgmt.get_api_version()))
return True return True
def set_ci(self, ci):
print "Push to Redfish"
return True
class Ironic(Driver): class Ironic(Driver):
pass pass
@ -97,7 +100,7 @@ class Mondorescue(Driver):
class Fakecmdb(Driver): class Fakecmdb(Driver):
def push_ci(self, ci): def set_ci(self, ci):
# Determine ci type so we can do the proper action. # Determine ci type so we can do the proper action.
pp = pprint.PrettyPrinter(indent=4) pp = pprint.PrettyPrinter(indent=4)
if ci.ci_type == "Manager": if ci.ci_type == "Manager":