vexxhost/libvirtd_exporter
Code Issues Proposed changes

Check conn status before close

Browse Source 
Change-Id: I0d2a69883dda556ffe5db623b2a29588f9c114cb
This commit is contained in:
okozachenko 2020-08-07 18:59:33 +03:00
parent 51d6e96278
commit c126e6c26c
2 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
collectors/domain_stats.go
View File

@ -313,11 +313,17 @@ func (c *DomainStatsCollector) Collect(ch chan<- prometheus.Metric) {
log.Errorln(err)
return
}
defer func() {
_, err := conn.Close()
alive, err := conn.IsAlive()
if err != nil {
log.Errorln(err)
return
}
if alive {
_, err := conn.Close()
if err != nil {
log.Errorln(err)
}
}
}()

10
collectors/version.go
View File

@ -52,11 +52,17 @@ func (c *VersionCollector) Collect(ch chan<- prometheus.Metric) {
log.Errorln(err)
return
}
defer func() {
_, err := conn.Close()
alive, err := conn.IsAlive()
if err != nil {
log.Errorln(err)
return
}
if alive {
_, err := conn.Close()
if err != nil {
log.Errorln(err)
}
}
}()