From 51d6e9627808fdf405ff1ce86f8e80b9cbf355da Mon Sep 17 00:00:00 2001 From: Mohammed Naser Date: Wed, 5 Aug 2020 22:15:39 -0400 Subject: [PATCH] Log close defer failures Change-Id: Ic9192425290d0da40631d9ba86f3219183c27243 --- collectors/domain_stats.go | 8 +++++++- collectors/version.go | 8 +++++++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/collectors/domain_stats.go b/collectors/domain_stats.go index f3e9c46..50f7260 100644 --- a/collectors/domain_stats.go +++ b/collectors/domain_stats.go @@ -313,7 +313,13 @@ func (c *DomainStatsCollector) Collect(ch chan<- prometheus.Metric) { log.Errorln(err) return } - defer conn.Close() + + defer func() { + _, err := conn.Close() + if err != nil { + log.Errorln(err) + } + }() stats, err := conn.GetAllDomainStats( []*libvirt.Domain{}, diff --git a/collectors/version.go b/collectors/version.go index 100c454..f0372f5 100644 --- a/collectors/version.go +++ b/collectors/version.go @@ -52,7 +52,13 @@ func (c *VersionCollector) Collect(ch chan<- prometheus.Metric) { log.Errorln(err) return } - defer conn.Close() + + defer func() { + _, err := conn.Close() + if err != nil { + log.Errorln(err) + } + }() hypervisorType, err := conn.GetType() if err != nil {