35 Commits

Author SHA1 Message Date
James E. Blair
6eebd81d86 Add some keyboard shortcuts to the change screen
Change-Id: I0f84d8b57d74329217795103b99c5205d38cc343
2014-05-05 13:46:54 -07:00
James E. Blair
ac295192e0 Colorize some buttons
Change-Id: I76c1bc22b5f0edb5064ce69428f94a2084aa9d7f
2014-05-05 13:46:47 -07:00
James E. Blair
5657a6d340 Add buttons to expand hidden context in diff
Change-Id: I5787a74cf5a31e512ef2649ea273fd0355009465
2014-05-05 10:24:00 -07:00
James E. Blair
227b6a0add Expand context as needed to include all comments
Use methods that can be re-used to support manually expanding
context by the user.

Also fix a s/old/new/ typo bug.

Change-Id: I5b247204b959add9fbfd51af7e508d3d07b7c001
2014-05-04 13:32:28 -07:00
James E. Blair
067aa68dcd Process more diff output
This gets up to 10,000 lines of diff context information, but does
not display it.  Now we have the data and in a future change can
display more context if needed in order to show comments or if the
user requests it.

Change-Id: Id569732ffa40610f67bf479de8bf936580fbacf1
2014-05-03 17:42:37 -07:00
James E. Blair
a44a82bff3 Refactor diff calculation to facilitate more context
Create groups of diff chunks and context chunks.  In a subsequent
change we can use that to better control the displayed context.

Change-Id: I75858d002e9a9fff809c91cfced81c6022d86196
2014-05-03 16:51:30 -07:00
Joshua Harlow
7a71108c60 Add a pbr compatible setup
Add a setup.cfg and setup.py and fill in those files
so that gertty can be installed easily.

Adjust gertty.py to have a main function that
can be referenced as a console entrypoint during
installation.

Also adjusted a bunch of imports that were failing after
installation occurred (but now they should not fail since they
correctly reference the gertty module namespace).

Change-Id: I532ced51583b26300ba9a2efb97f8e41bc69ec8d
2014-05-03 11:54:49 -07:00
James E. Blair
6505505369 Add a welcome screen
If gertty starts with no subscribed projects, display some help
text to help the user get started.

Change-Id: I1ac89321ea0e3129e00e505abfb1821d0cb28b45
2014-05-02 20:37:23 -07:00
James E. Blair
0415539a9f Make all of the change view scrollable
Which makes better use of vertical space.

Also, tuck the votes box in under the change info (so it doesn't
start below a very long commit message -- that wastes a lot of
space).

Change-Id: Ia7d216ce584221fa5055e1a7e5e6fba1ed94b399
2014-05-02 20:15:11 -07:00
James E. Blair
68c51ffdb7 Add a Quit dialog
Remove the contextlib pipe close feature -- file descriptors are
closed on program exit anyway.  Letting that happen normally
actually makes exiting with CTRL-C nicer (fewer race conditions).

Map "CTRL-Q" to the quit command, but pop up a yes/no dialog.

Refactor the MessageDialog into a ButtonDialog base class that
can serve MessageDialog and YesNoDialog.

Add global help text that is prepended to each screen's help text
to deal with the growing number of global commands.

Change-Id: I455344cb20fb19032a3964d602fc886e19f256e5
2014-05-02 19:43:07 -07:00
Joshua Harlow
5500eca644 Handle exiting more gracefully
Set all threads to daemon mode and close
the write end of the pipe when exiting to
ensure we cleanup in a friendly manner.

Change-Id: I4cf64fa39e820c95d11943b848db87e5db15212e
2014-04-30 20:36:47 -07:00
Jenkins
7898f63698 Merge "Handle binary files in diffstat" 2014-04-30 21:43:35 +00:00
Jenkins
ad04430772 Merge "Handle file renames in diff view" 2014-04-30 21:43:14 +00:00
Jenkins
1f888258a4 Merge "Handle "No newline at end of file" and add --no-sync option" 2014-04-30 21:42:10 +00:00
Jenkins
1d417143c3 Merge "Fix editing inline comments" 2014-04-30 21:42:05 +00:00
Jenkins
5097b2ad9b Merge "Normalize URL to ends with a slash" 2014-04-30 21:41:32 +00:00
Jenkins
4efe31cf35 Merge "Properly register password from prompt" 2014-04-30 21:41:27 +00:00
James E. Blair
989bccaa22 Handle binary files in diffstat
Added/removed counts are "-".

Change-Id: I339a91019f700106bae92b200aa554876065ea62
2014-04-30 14:14:04 -07:00
James E. Blair
0a0ae71ea4 Handle file renames in diff view
Change-Id: I809a0bddc2ca45f9b5789abeb770cf55d068f87d
2014-04-30 13:29:47 -07:00
James E. Blair
dfeef53895 Handle "No newline at end of file" and add --no-sync option
Change-Id: Ic40e4151eeacfd0514f5bdfb7eb268b0a08eb19b
2014-04-30 10:01:37 -07:00
James E. Blair
f15feec7bf Fix editing inline comments
An earlier change broke editing comments.

Change-Id: I7c10d29088bf15145c864843529c243c7c0c1169
2014-04-30 09:21:33 -07:00
James E. Blair
437bf21383 Make ordereddict optional
Change-Id: I73d6eccb25bf6d72471b9b23b537a8041e131b20
2014-04-30 08:52:24 -07:00
Antoine Musso
c7d600ab01 Normalize URL to ends with a slash
Change-Id: Ib32f6aed1fffa636740113b17786c6ace305c300
2014-04-30 17:18:19 +02:00
Antoine Musso
993bf7b204 Properly register password from prompt
Whenever the password field is missing from the conf, gertty prompts the
user to enter it but hapilly discard it to a local variable.  Set the
config password field instead.

Change-Id: Idf6ea2edd9396e4e635955519af6739106fbfe3c
2014-04-30 17:04:14 +02:00
Antoine Musso
47de985ba7 Print a friendly user message when conf is missing
Change-Id: I03b3087cb78008a15b0f43b8d63832d15e388fc1
2014-04-30 16:56:28 +02:00
Jenkins
c82f98cc03 Merge "Fix some diff comment display errors" 2014-04-30 14:03:33 +00:00
James E. Blair
d924789cf9 Fix some diff comment display errors
Change-Id: I0106e302feb6d3c02faa3fa7b6faf7907e833d5f
2014-04-29 20:22:14 -07:00
Jenkins
283f60d046 Merge "Fix displaying new files" 2014-04-30 01:23:14 +00:00
Jenkins
6930968536 Merge "Add ordereddict requirement" 2014-04-30 01:22:12 +00:00
James E. Blair
5585ba6786 Fix displaying new files
Change-Id: Idacb212482b33574ba71bf8f90b62b594616b77a
Closes-Task: some subtask of story 70
2014-04-29 18:19:36 -07:00
Joshua Harlow
8205010884 Add ordereddict requirement
OrderedDict isn't in python 2.6 which is on some
older distros (still), so import the package that
provides it when it can not be found.

Change-Id: I9637d346e85c651e8e242025b9e88b1af3d8fca0
2014-04-29 17:54:46 -07:00
Joshua Harlow
6a3ef5e1a7 Allow for password prompting
If the users password isn't in their configuration
file, then use getpass to prompt for it instead.

Change-Id: Ib0d53e181fffc455e8555cdb26125f2891695387
2014-04-29 17:50:03 -07:00
Joshua Harlow
b3ea5cf5e2 Read using a file handle instead of read() method
The read() method silently ignores errors which is
not so useful if .gerttyrc doesn't exist, so instead
of using that use the readfp which will open the file
and then correctly read from the file (and raise if
the file does not exist).

Change-Id: I3bf68408595e06c6ffb60632b46995c1fadbea3f
2014-04-29 17:42:44 -07:00
James E. Blair
1d6b0fd881 Initial commit
Change-Id: Ie79f257c46a2c50abdd7ce63bfeceaad976ca878
2014-04-29 16:28:49 -07:00
OpenStack Project Creator
0b7ce7d3a2 Added .gitreview 2014-04-29 17:38:33 +00:00