The example for multi-key handling, setting quit to ":q", did not
work because the key buffer clearing at the project screen was
interfering with the key buffering for unhandled input at the top
level. Correct this by only clearing the keybuffer in the project
screen if that screen handled a command. Otherwise, let the
unhandled input handler clear it if necessary.
Change-Id: I104141ceaa87e6178ca74467a55cb7a944ad0128
Commit I0cd0884e0e1f4f0fa82f93e5f7438ff00c5a992aadded support for
sequences of keys input but config file validation was not updated to
reflect the change.
Change-Id: I9c648686737262148a16d3228413da5939677000
Detect the gerrit version on startup and on any reconnection.
When submitting commit message edits, use the change edit API
in 2.11 or greater as the old API has been removed.
Change-Id: Idcba9fc6d424311658b0470410c820015bac9590
Add a simple interactive search to the diff view. This is bound
to C-s by default. It highlights text, but does not yet navigate.
Change-Id: Ic795bb5d18911590237b6595f812e10fd4baa1ce
Create a global app kill ring and a custom edit widget that can
kill and yank from it. Also, add Emacs beginning/end of line
keys to the default keymap.
Change-Id: I18d8d47694c89ede4dcec7eaf5d3fb2210ef4438
Exherbo has a setup where gerrit is at
https://galileo.mailstation.de/gerrit/ and jenkins is at
https://galileo.mailstation.de/jenkins/. gertty falsely thinks that the
jenkins link is a change and when clicked it weirdly starts to sync
random projects for 10 minutes before telling me that the change is not
found. This patch fixes it by matching on the full url.
Change-Id: I4261fce74d6cfaec736e478747592b001d82400d
Being able to refine a search query is useful, but so is being able
to quickly open a specific change from anywhere. Separate these
commands. C-o opens a blank search input; M-o opens a search input
pre-filled with th ecurrent query in list view.
Change-Id: I49d0f076354322a2652de515d476548926a99182
If a change has comments on a file that is not in a patchset,
Gertty will fail to sync the change because local db entries for
files are only created if the file is actually in the revision.
If a comment appears for an unknown file, create an entry in
the db for that file. Note, this will cause the change to appear
in "file:" queries that match that file. It's not clear to me
that is incorrect.
Change-Id: I4916b85a5cbd72ced6682448b774752f3f6cc821
The addition of the ability to review multiple changes at once from the
change_list view duplicates the reverse_order keybinding. They both use
'r'.
Change the reverse_order binding to 'R'.
See, https://storyboard.openstack.org/#!/story/2000290
Change-Id: I3728948a55060ff9f1bd28352474fc4479e68ab9
This change allows a user to click the permalink on the review screen
and have it open up in a web browser.
Change-Id: I4c0fe35f062043a47368d68fecbbcdbf8d955267
After launching a browser child process, gertty's display may no
longer be current (e.g., when using a console-based browser).
Redisplay the screen contents following browser execution as a
prophylactic measure.
Note: you can test this by invoking `BROWSER=lynx gertty` with lynx
installed (but really, can you call it a computer if it doesn't have
lynx installed?!?).
Change-Id: I929e6ec4252b3e4c7c8c425a87cc8be7c0434828
Fix the error:
AttributeError: 'App' object has no attribute 'git_root'
That was not quite fixed by I55103b71e7fe35e282d69c3c95c61cbad95ef729
Change-Id: I28eb4f24b184f2843e25516450b3d145204a8828
When opening the search dialog from a change list, use the current
query as the default value. This lets you iterate on a query
without needing to type or copy it repeatedly. However, it does
mean that you need to clear out the field if you want a completely
different query.
Change-Id: I1f31db1cde0b86c5a7b214866f1df686dd901c7c
I commented on a review while offline yesterday. When I came online,
someone had provided a -2. Being a more-negative comment than mine, this
held my change, and added a warning in the top-right to tell me I had a
held change.
However, I couldn't *see* the held change in held-changes view, because
it only shows me open changes - and this particular change was abandoned
after the -2.
This change makes held-changes view show all held changes,not just open
held changes.
An alternative here might be to not warn the user about held changes if
they have been abandoned; but that could be confusing if my comment had
been "I think this shouldn't be abandoned because"....
Change-Id: I5165f50af30b51ae29f2639dd5fd4185b02aa1fa
Some places where we call getRepo were missed in the recent move
to gitrepo.get_repo. Correct those and also remove excess module
qualifications.
Change-Id: I55103b71e7fe35e282d69c3c95c61cbad95ef729
The Database and SearchParser classes didn't really need the app object.
They just needed to use some of its properties. Instead those properties
are just being passed in.
Change-Id: Iabdd0072a8f74e6b9346fe03c15cfa00810e1c4a
The getRepo method really doesn't have much to do with the application
object. Since it's really a utiltiy method for dealing with git repos
I've moved it to gertty.gitrepo.
Change-Id: Ic3349430c456ee184bbf57b6e5b7de4f940b4cc1
A logic error in the method to pretty-print file renames could cause
a crash. Ensure that we don't overrun the length of either the
old or new path when comparing.
Change-Id: I7f1006ec6cbdb723e77cb62b64414a960af04113
The change to avoid duplicate tasks in a queue had an error where
it would cause all tasks to be immediately marked as completed.
This caused the synchronous task waits on actions such as immediate
sync of a single change to return early, before actual completion.
This may have caused other errors as well.
Change-Id: Ie000a1242db17b1bed8c2eac919e242225f5bba6
0.11 has a fix for an alembic migration problem that has plagued
Gertty early adopters. 1.0 is out as well and will work, so it
is safe to set the semver cap at 2.0.
Change-Id: I5426fabcfa79e32a9bc1c2c91f10d4f20ff7b913
Reviewing multiple changes is accomplished by setting the process
mark; also allow reviewing a single change from the change list
if the process mark is not set.
Change-Id: Id615ab084d576307fd2b13d31a20842763c9aca7
If a flag (hold, mark, starred) was changed, the row would lose
the threading indication. Correct this.
Change-Id: I91aa6c2df4164c8e539e8bd1cf5bd703ddd5e58b
Add a process mark to the change list so that multiple changes may
be selected at once for further operations. Allow multiple changes
to be reviwed at once by selecting them with the process mark and
then pressing the usual review command key. The categories are
simply taken from the first change in the list for simplicity.
This should be fine most of the time, but if the changes have
different categories available to them, or the user has different
access levels, this may not behave as intended.
Change-Id: I04a790d91b27b270cf1269c7bcb39c12d857ab32
