ttygroup/boartty
Code Issues Proposed changes

Only sync parent commit once

Browse Source 
When a revision's parent commit is not known locally, it is added
to the sync queue.  However, if multiple revisions of a change have
the same parent (which is common) a sync task will be added for
each copy.  Instead, keep track of the parents of each revision
of a change and only sync each such commit once.

Change-Id: Ibe8fc80d87b338b6da9d529b1be38c7c4efb65f4
This commit is contained in:
James E. Blair 2015-03-11 07:29:36 -07:00
parent 461a0eee45
commit d7555e3263
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
gertty/sync.py
View File

@ -362,6 +362,7 @@ class SyncChangeTask(Task):
remote_comments_data = sync.get('changes/%s/revisions/%s/comments' % (self.change_id, remote_commit))
remote_revision['_gertty_remote_comments_data'] = remote_comments_data
fetches = collections.defaultdict(list)
parent_commits = set()
with app.db.getSession() as session:
change = session.getChangeByID(self.change_id)
account = session.getAccountByID(remote_change['owner']['_account_id'],
@ -420,15 +421,17 @@ class SyncChangeTask(Task):
self.log.info("Created new revision %s for change %s revision %s in local DB.", revision.key, self.change_id, remote_revision['_number'])
new_revision = True
revision.message = remote_revision['commit']['message']
# TODO: handle multiple parents
parent_revision = session.getRevisionByCommit(revision.parent)
actions = remote_revision.get('actions', {})
revision.can_submit = 'submit' in actions
# TODO: use a singleton list of closed states
if not parent_revision and change.status not in ['MERGED', 'ABANDONED']:
sync.submitTask(SyncChangeByCommitTask(revision.parent, self.priority))
self.log.debug("Change %s revision %s needs parent commit %s synced" %
(change.id, remote_revision['_number'], revision.parent))
# TODO: handle multiple parents
if revision.parent not in parent_commits:
parent_revision = session.getRevisionByCommit(revision.parent)
# TODO: use a singleton list of closed states
if not parent_revision and change.status not in ['MERGED', 'ABANDONED']:
sync.submitTask(SyncChangeByCommitTask(revision.parent, self.priority))
self.log.debug("Change %s revision %s needs parent commit %s synced" %
(change.id, remote_revision['_number'], revision.parent))
parent_commits.add(revision.parent)
result.updateRelatedChanges(session, change)
remote_comments_data = remote_revision['_gertty_remote_comments_data']
for remote_file, remote_comments in remote_comments_data.items():