ttygroup/boartty
Code Issues Proposed changes

Change review toggle keybinding to 'v'.

Browse Source 
So that the review toggle command can have the same keybinding
in the change list and change view, switch it to 'v'.  'r' and 'd'
are other candidates but both make more sense for the 'review' and
'diff' commands in the change view.

Change-Id: I806fd528cc6fa648450d69181aadbacd67548dda
This commit is contained in:
James E. Blair 2014-05-17 18:36:02 -04:00
parent 4abd095419
commit c9f094a62f
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gertty/view/change.py
View File

@ -260,10 +260,10 @@ class ChangeView(urwid.WidgetWrap):
help = mywid.GLOBAL_HELP + """ help = mywid.GLOBAL_HELP + """
This Screen This Screen
=========== ===========
<R> Toggle the reviewed flag for the current change.
<c> Checkout the most recent revision. <c> Checkout the most recent revision.
<d> Show the diff of the mont recent revision. <d> Show the diff of the mont recent revision.
<r> Leave a review for the most recent revision. <r> Leave a review for the most recent revision.
<v> Toggle the reviewed flag for the current change.
""" """
def __init__(self, app, change_key): def __init__(self, app, change_key):
@ -420,7 +420,7 @@ This Screen
def keypress(self, size, key): def keypress(self, size, key):
r = super(ChangeView, self).keypress(size, key) r = super(ChangeView, self).keypress(size, key)
if r == 'R': if r == 'v':
self.toggleReviewed() self.toggleReviewed()
self.refresh() self.refresh()
return None return None

4
gertty/view/change_list.py
View File

@ -69,7 +69,7 @@ class ChangeListView(urwid.WidgetWrap):
This Screen This Screen
=========== ===========
<l> Toggle whether only unreviewed or all changes are displayed. <l> Toggle whether only unreviewed or all changes are displayed.
<r> Toggle the reviewed flag for the currently selected change. <v> Toggle the reviewed flag for the currently selected change.
""" """
def __init__(self, app, project_key): def __init__(self, app, project_key):
@ -129,7 +129,7 @@ This Screen
self.unreviewed = not self.unreviewed self.unreviewed = not self.unreviewed
self.refresh() self.refresh()
return None return None
if key=='r': if key=='v':
if not len(self.listbox.body): if not len(self.listbox.body):
return None return None
pos = self.listbox.focus_position pos = self.listbox.focus_position