ttygroup/boartty
Code Issues Proposed changes

Merge "Fix reversing changes"

Browse Source
This commit is contained in:
Jenkins 2015-02-27 00:07:12 +00:00 committed by Gerrit Code Review
commit 8971fcc965
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gertty/view/change_list.py
View File

@ -200,7 +200,7 @@ class ChangeListView(urwid.WidgetWrap):
def refresh(self): def refresh(self):
unseen_keys = set(self.change_rows.keys()) unseen_keys = set(self.change_rows.keys())
with self.app.db.getSession() as session: with self.app.db.getSession() as session:
lst = session.getChanges(self.query, self.unreviewed, change_list = session.getChanges(self.query, self.unreviewed,
sort_by=self.sort_by) sort_by=self.sort_by)
if self.unreviewed: if self.unreviewed:
self.title = u'Unreviewed changes in %s' % self.query_desc self.title = u'Unreviewed changes in %s' % self.query_desc
@ -208,14 +208,12 @@ class ChangeListView(urwid.WidgetWrap):
self.title = u'All changes in %s' % self.query_desc self.title = u'All changes in %s' % self.query_desc
self.app.status.update(title=self.title) self.app.status.update(title=self.title)
categories = set() categories = set()
for change in lst: for change in change_list:
categories |= set(change.getCategories()) categories |= set(change.getCategories())
self.categories = sorted(categories) self.categories = sorted(categories)
i = 0 i = 0
if self.reverse: if self.reverse:
change_list = reversed(lst) change_list.reverse()
else:
change_list = lst
if self.app.config.thread_changes: if self.app.config.thread_changes:
change_list = self._threadChanges(change_list) change_list = self._threadChanges(change_list)
new_rows = [] new_rows = []
@ -244,7 +242,7 @@ class ChangeListView(urwid.WidgetWrap):
else: else:
pos = min(focus_pos, len(self.listbox.body)-1) pos = min(focus_pos, len(self.listbox.body)-1)
self.listbox.body.set_focus(pos) self.listbox.body.set_focus(pos)
if lst: if change_list:
self.header.update(self.categories) self.header.update(self.categories)
for key in unseen_keys: for key in unseen_keys:
row = self.change_rows[key] row = self.change_rows[key]