From 84e072e172a883cb9b022cb95f6f612a4fd4a5b4 Mon Sep 17 00:00:00 2001 From: "James E. Blair" Date: Fri, 16 Jan 2015 14:41:37 +1300 Subject: [PATCH] Protect against null owner in change view If the change has no owner, do not dereference it in the change screen. Change-Id: I1c7b256ae882a59a1107f203bbb5a2f97feb59f0 --- gertty/view/change.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gertty/view/change.py b/gertty/view/change.py index d91e57b..6ff3669 100644 --- a/gertty/view/change.py +++ b/gertty/view/change.py @@ -553,7 +553,10 @@ class ChangeView(urwid.WidgetWrap): self.app.status.update(title=self.title) self.project_key = change.project.key self.change_rest_id = change.id - self.owner_email = change.owner.email + if change.owner: + self.owner_email = change.owner.email + else: + self.owner_email = None self.change_id_label.set_text(('change-data', change.change_id)) self.owner_label.text.set_text(('change-data', change.owner_name)) @@ -989,7 +992,8 @@ class ChangeView(urwid.WidgetWrap): self.refresh() def searchOwner(self, widget): - self.app.doSearch("status:open owner:%s" % (self.owner_email,)) + if self.owner_email: + self.app.doSearch("status:open owner:%s" % (self.owner_email,)) def reviewKey(self, reviewkey): approvals = {}