ttygroup/boartty
Code Issues Proposed changes

Protect against null owner in change view

Browse Source 
If the change has no owner, do not dereference it in the change
screen.

Change-Id: I1c7b256ae882a59a1107f203bbb5a2f97feb59f0
This commit is contained in:
James E. Blair 2015-01-16 14:41:37 +13:00
parent bfb5deff32
commit 84e072e172
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gertty/view/change.py
View File

@ -553,7 +553,10 @@ class ChangeView(urwid.WidgetWrap):
self.app.status.update(title=self.title)
self.project_key = change.project.key
self.change_rest_id = change.id
self.owner_email = change.owner.email
if change.owner:
self.owner_email = change.owner.email
else:
self.owner_email = None
self.change_id_label.set_text(('change-data', change.change_id))
self.owner_label.text.set_text(('change-data', change.owner_name))
@ -989,7 +992,8 @@ class ChangeView(urwid.WidgetWrap):
self.refresh()
def searchOwner(self, widget):
self.app.doSearch("status:open owner:%s" % (self.owner_email,))
if self.owner_email:
self.app.doSearch("status:open owner:%s" % (self.owner_email,))
def reviewKey(self, reviewkey):
approvals = {}