ttygroup/boartty
Code Issues Proposed changes

Add some INFO level log messages

Browse Source 
Adds INFO level log message for successful atomic units of work in the
Sync tasks.

Change-Id: I4c5a69a1ad124d7a75e2f1843f23fd1d0d9cb7e9
This commit is contained in:
Jay Pipes 2014-12-19 14:44:11 -05:00 committed by James E. Blair
parent 823c587a12
commit 76ad79278b
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
gertty/sync.py
View File

@ -174,6 +174,7 @@ class SyncProjectListTask(Task):
p = remote[name] p = remote[name]
project = session.createProject(name, project = session.createProject(name,
description=p.get('description', '')) description=p.get('description', ''))
self.log.info("Created project %s", project.name)
self.results.append(ProjectAddedEvent(project)) self.results.append(ProjectAddedEvent(project))
class SyncSubscribedProjectBranchesTask(Task): class SyncSubscribedProjectBranchesTask(Task):
@ -213,12 +214,12 @@ class SyncProjectBranchesTask(Task):
local_branches = set(local.keys()) local_branches = set(local.keys())
for name in local_branches-remote_branches: for name in local_branches-remote_branches:
self.log.debug("Delete branch %s from project %s" % (name, project.name))
session.delete(local[name]) session.delete(local[name])
self.log.info("Deleted branch %s from project %s in local DB.", name, project.name)
for name in remote_branches-local_branches: for name in remote_branches-local_branches:
self.log.debug("Add branch %s to project %s" % (name, project.name))
project.createBranch(name) project.createBranch(name)
self.log.info("Added branch %s to project %s in local DB.", name, project.name)
class SyncSubscribedProjectsTask(Task): class SyncSubscribedProjectsTask(Task):
def __repr__(self): def __repr__(self):
@ -287,7 +288,6 @@ class SyncProjectTask(Task):
# in the db optionally we could sync all changes ever # in the db optionally we could sync all changes ever
if c['id'] in change_ids or (c['status'] not in self._closed_statuses): if c['id'] in change_ids or (c['status'] not in self._closed_statuses):
sync.submitTask(SyncChangeTask(c['id'], priority=self.priority)) sync.submitTask(SyncChangeTask(c['id'], priority=self.priority))
self.log.debug("Change %s update %s" % (c['id'], c['updated']))
for key in self.project_keys: for key in self.project_keys:
sync.submitTask(SetProjectUpdatedTask(key, now, priority=self.priority)) sync.submitTask(SetProjectUpdatedTask(key, now, priority=self.priority))
@ -354,6 +354,7 @@ class SyncChangeTask(Task):
return '<SyncChangeTask %s>' % (self.change_id,) return '<SyncChangeTask %s>' % (self.change_id,)
def run(self, sync): def run(self, sync):
start_time = time.time()
app = sync.app app = sync.app
remote_change = sync.get('changes/%s?o=DETAILED_LABELS&o=ALL_REVISIONS&o=ALL_COMMITS&o=MESSAGES&o=DETAILED_ACCOUNTS&o=CURRENT_ACTIONS' % self.change_id) remote_change = sync.get('changes/%s?o=DETAILED_LABELS&o=ALL_REVISIONS&o=ALL_COMMITS&o=MESSAGES&o=DETAILED_ACCOUNTS&o=CURRENT_ACTIONS' % self.change_id)
# Perform subqueries this task will need outside of the db session # Perform subqueries this task will need outside of the db session
@ -376,6 +377,7 @@ class SyncChangeTask(Task):
remote_change['subject'], created, remote_change['subject'], created,
updated, remote_change['status'], updated, remote_change['status'],
topic=remote_change.get('topic')) topic=remote_change.get('topic'))
self.log.info("Created new change %s in local DB.", change.id)
result = ChangeAddedEvent(change) result = ChangeAddedEvent(change)
else: else:
result = ChangeUpdatedEvent(change) result = ChangeUpdatedEvent(change)
@ -415,6 +417,7 @@ class SyncChangeTask(Task):
remote_revision['commit']['message'], remote_commit, remote_revision['commit']['message'], remote_commit,
remote_revision['commit']['parents'][0]['commit'], remote_revision['commit']['parents'][0]['commit'],
auth, ref) auth, ref)
self.log.info("Created new revision %s for change %s in local DB.", revision.key, self.change_id)
new_revision = True new_revision = True
revision.message = remote_revision['commit']['message'] revision.message = remote_revision['commit']['message']
# TODO: handle multiple parents # TODO: handle multiple parents
@ -446,6 +449,7 @@ class SyncChangeTask(Task):
created, created,
remote_file, parent, remote_comment.get('line'), remote_file, parent, remote_comment.get('line'),
remote_comment['message']) remote_comment['message'])
self.log.info("Created new comment %s for revision %s in local DB.", comment.key, revision.key)
else: else:
if comment.author != account: if comment.author != account:
comment.author = account comment.author = account
@ -467,6 +471,7 @@ class SyncChangeTask(Task):
created = dateutil.parser.parse(remote_message['date']) created = dateutil.parser.parse(remote_message['date'])
message = revision.createMessage(remote_message['id'], account, created, message = revision.createMessage(remote_message['id'], account, created,
remote_message['message']) remote_message['message'])
self.log.info("Created new review message %s for revision %s in local DB.", message.key, revision.key)
else: else:
if message.author != account: if message.author != account:
message.author = account message.author = account
@ -520,6 +525,7 @@ class SyncChangeTask(Task):
change.createApproval(account, change.createApproval(account,
remote_approval['category'], remote_approval['category'],
remote_approval['value']) remote_approval['value'])
self.log.info("Created approval for change %s in local DB.", change.id)
for key in remote_label_keys-local_label_keys: for key in remote_label_keys-local_label_keys:
remote_label = remote_label_entries[key] remote_label = remote_label_entries[key]
@ -576,6 +582,9 @@ class SyncChangeTask(Task):
for ref in refs: for ref in refs:
self.log.debug("git fetch %s %s" % (url, ref)) self.log.debug("git fetch %s %s" % (url, ref))
repo.fetch(url, ref) repo.fetch(url, ref)
end_time = time.time()
total_time = end_time - start_time
self.log.info("Synced change %s in %0.5f seconds.", self.change_id, total_time)
class CheckReposTask(Task): class CheckReposTask(Task):
# on startup, check all projects # on startup, check all projects