ttygroup/boartty
Code Issues Proposed changes

Include more info in dependencies

Browse Source 
Indicate if a change depends on an obsolete revision of another
change.  Also, indicate that a change is needed by a change even
if the dependency is on an older patchset.

Change-Id: I8f1653c917979d3865d5e494cd53789e65ea928b
This commit is contained in:
James E. Blair 2014-08-20 15:11:46 -07:00
parent 823ccfb3a3
commit 710afa5b45
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
gertty/view/change.py
View File

@ -532,15 +532,23 @@ class ChangeView(urwid.WidgetWrap):
parents = {} parents = {}
parent = session.getRevisionByCommit(revision.parent) parent = session.getRevisionByCommit(revision.parent)
if parent and parent.change.status != 'MERGED': if parent and parent.change.status != 'MERGED':
parents[parent.change.key] = parent.change.subject subject = parent.change.subject
if parent != parent.change.revisions[-1]:
subject += ' [OUTDATED]'
parents[parent.change.key] = subject
self._updateDependenciesWidget(parents, self._updateDependenciesWidget(parents,
self.depends_on, self.depends_on_rows, self.depends_on, self.depends_on_rows,
header='Depends on:') header='Depends on:')
# Handle needed-by # Handle needed-by
children = dict((r.change.key, r.change.subject) children = {}
for r in session.getRevisionsByParent(revision.commit) for revision in change.revisions:
if r.change.status != 'MERGED') children.update((r.change.key, r.change.subject)
for r in session.getRevisionsByParent(revision.commit)
if (r.change.status != 'MERGED' and
r == r.change.revisions[-1]))
for x in children:
self.app.log.debug("needed by %s" % x)
self._updateDependenciesWidget(children, self._updateDependenciesWidget(children,
self.needed_by, self.needed_by_rows, self.needed_by, self.needed_by_rows,
header='Needed by:') header='Needed by:')