From 710afa5b4555b6e4c4185aedbcefb14c4522bd0d Mon Sep 17 00:00:00 2001 From: "James E. Blair" Date: Wed, 20 Aug 2014 15:11:46 -0700 Subject: [PATCH] Include more info in dependencies Indicate if a change depends on an obsolete revision of another change. Also, indicate that a change is needed by a change even if the dependency is on an older patchset. Change-Id: I8f1653c917979d3865d5e494cd53789e65ea928b --- gertty/view/change.py | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/gertty/view/change.py b/gertty/view/change.py index 3dc8c8e..483ad88 100644 --- a/gertty/view/change.py +++ b/gertty/view/change.py @@ -532,15 +532,23 @@ class ChangeView(urwid.WidgetWrap): parents = {} parent = session.getRevisionByCommit(revision.parent) if parent and parent.change.status != 'MERGED': - parents[parent.change.key] = parent.change.subject + subject = parent.change.subject + if parent != parent.change.revisions[-1]: + subject += ' [OUTDATED]' + parents[parent.change.key] = subject self._updateDependenciesWidget(parents, self.depends_on, self.depends_on_rows, header='Depends on:') # Handle needed-by - children = dict((r.change.key, r.change.subject) - for r in session.getRevisionsByParent(revision.commit) - if r.change.status != 'MERGED') + children = {} + for revision in change.revisions: + children.update((r.change.key, r.change.subject) + for r in session.getRevisionsByParent(revision.commit) + if (r.change.status != 'MERGED' and + r == r.change.revisions[-1])) + for x in children: + self.app.log.debug("needed by %s" % x) self._updateDependenciesWidget(children, self.needed_by, self.needed_by_rows, header='Needed by:')