From 70d3357e983291fb029acc855eff0cbd0d4ebd6a Mon Sep 17 00:00:00 2001 From: Matthew Treinish Date: Wed, 19 Nov 2014 16:53:54 -0500 Subject: [PATCH] Fix vote order in review dialog box This commit fixes the vote order in the review dialog box to match what is in the gerrit web ui. With +2/+1 on top and -2/-1 on the bottom. This has been a source of common mistakes for new users of gertty coming from the gerrit web ui. Change-Id: I30b7854565f17c2802dff685a67c10e78588280c --- gertty/view/change.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gertty/view/change.py b/gertty/view/change.py index 096e15f..1f9da74 100644 --- a/gertty/view/change.py +++ b/gertty/view/change.py @@ -127,7 +127,7 @@ class ReviewDialog(urwid.WidgetWrap): current = 0 else: current = current.value - for value in values[category]: + for value in sorted(values[category], reverse=True): if value > 0: strvalue = '+%s' % value elif value == 0: