ttygroup/boartty
Code Issues Proposed changes

Fix vote order in review dialog box

Browse Source 
This commit fixes the vote order in the review dialog box to match
what is in the gerrit web ui. With +2/+1 on top and -2/-1 on the
bottom. This has been a source of common mistakes for new users
of gertty coming from the gerrit web ui.

Change-Id: I30b7854565f17c2802dff685a67c10e78588280c
This commit is contained in:
Matthew Treinish 2014-11-19 16:53:54 -05:00
parent 9285a97f4a
commit 70d3357e98
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gertty/view/change.py
View File

@ -127,7 +127,7 @@ class ReviewDialog(urwid.WidgetWrap):
current = 0
else:
current = current.value
for value in values[category]:
for value in sorted(values[category], reverse=True):
if value > 0:
strvalue = '+%s' % value
elif value == 0: