ttygroup/boartty
Code Issues Proposed changes

Removed closed changes from unreviewed list.

Browse Source 
Previously any MERGED or ABANDONED changes showed up in the unreviewed
changes list for a project unless explicitly reviewed by the gertty
user. This is problematic because changes in these states are closed and
don't need further review. Remove them from the unreviewed list to cut
down on noise.

Note this is not symmetric currently with listing reviewed changes and
all changes. I think gertty should also learn to ignore and remove
MERGED changes from its DB entirely at some point. But not quite sure
how we want to do that. Might only be useful to do that after we add the
ability to view specific changes.

Change-Id: I951a687250b79eec7eca00f877cb1cb50e867c09
This commit is contained in:
Clark Boylan 2014-05-07 18:35:55 -07:00 committed by James E. Blair
parent e5666d006b
commit 478d10cef9
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gertty/db.py
View File

@ -283,6 +283,8 @@ mapper(Project, project_table, properties=dict(
unreviewed_changes=relationship(Change,
primaryjoin=and_(project_table.c.key==change_table.c.project_key,
change_table.c.hidden==False,
change_table.c.status!='MERGED',
change_table.c.status!='ABANDONED',
change_table.c.reviewed==False),
order_by=change_table.c.number,
),