From 32eb13939dde4a1ee8940179010bc048e5cabbf6 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Thu, 11 Sep 2014 07:05:24 +0200 Subject: [PATCH] Use owner's username or email if display name is not set If a change owner does not have a display name configured, the change list doesn't display any name. Rather than displaying nothing, attempt to use the username or email instead if one of them is configured. If no display name, username or email is set for the owner, default to 'Anonymous Coward'. Change-Id: Ifa2c56d89ed3d9b24e67643e460cacc133db90dd --- gertty/view/change_list.py | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/gertty/view/change_list.py b/gertty/view/change_list.py index 9227a50..1a3225c 100644 --- a/gertty/view/change_list.py +++ b/gertty/view/change_list.py @@ -57,10 +57,15 @@ class ChangeRow(urwid.Button): self.subject.set_text(change.subject) self.number.set_text(str(change.number)) self.project.set_text(change.project.name.split('/')[-1]) - if change.owner and change.owner.name: - self.owner.set_text(change.owner.name) - else: - self.owner.set_text(u'') + owner_name = 'Anonymous Coward' + if change.owner: + if change.owner.name: + owner_name = change.owner.name + elif change.owner.username: + owner_name = change.owner.username + elif change.owner.email: + owner_name = change.owner.email + self.owner.set_text(owner_name) del self.columns.contents[self.num_columns:] for category in change.getCategories(): v = change.getMaxForCategory(category)