Show all held changes in held-changes view

I commented on a review while offline yesterday. When I came online,
someone had provided a -2. Being a more-negative comment than mine, this
held my change, and added a warning in the top-right to tell me I had a
held change.

However, I couldn't *see* the held change in held-changes view, because
it only shows me open changes - and this particular change was abandoned
after the -2.

This change makes held-changes view show all held changes,not just open
held changes.

An alternative here might be to not warn the user about held changes if
they have been abandoned; but that could be confusing if my comment had
been "I think this shouldn't be abandoned because"....

Change-Id: I5165f50af30b51ae29f2639dd5fd4185b02aa1fa
This commit is contained in:
James Polley 2015-07-02 12:08:43 +10:00
parent 574c9b36f5
commit 31af7ed182

View File

@ -516,7 +516,7 @@ class App(object):
elif keymap.CHANGE_SEARCH in commands:
self.searchDialog()
elif keymap.LIST_HELD in commands:
self.doSearch("status:open is:held")
self.doSearch("is:held")
elif key in self.config.dashboards:
d = self.config.dashboards[key]
view = view_change_list.ChangeListView(self, d['query'], d['name'])