ttygroup/boartty
Code Issues Proposed changes

Include descriptions in review dialog

Browse Source 
Include the category description (eg "looks good to me") next to
the review values (eg "+1").

Change-Id: Ibd36da053bfa311097e72a7029d5dc6141169d57
This commit is contained in:
James E. Blair 2015-01-13 16:16:28 +13:00
parent 70d3357e98
commit 154ddc8766
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gertty/view/change.py
View File

@ -104,12 +104,16 @@ class ReviewDialog(urwid.WidgetWrap):
rows = [] rows = []
categories = [] categories = []
values = {} values = {}
descriptions = {}
self.button_groups = {} self.button_groups = {}
message = '' message = ''
with self.app.db.getSession() as session: with self.app.db.getSession() as session:
revision = session.getRevision(self.revision_row.revision_key) revision = session.getRevision(self.revision_row.revision_key)
change = revision.change change = revision.change
if revision == change.revisions[-1]: if revision == change.revisions[-1]:
for label in change.labels:
d = descriptions.setdefault(label.category, {})
d[label.value] = label.description
for label in change.permitted_labels: for label in change.permitted_labels:
if label.category not in categories: if label.category not in categories:
categories.append(label.category) categories.append(label.category)
@ -134,7 +138,9 @@ class ReviewDialog(urwid.WidgetWrap):
strvalue = ' 0' strvalue = ' 0'
else: else:
strvalue = str(value) strvalue = str(value)
strvalue += ' ' + descriptions[category][value]
b = urwid.RadioButton(group, strvalue, state=(value == current)) b = urwid.RadioButton(group, strvalue, state=(value == current))
b._value = value
rows.append(b) rows.append(b)
rows.append(urwid.Divider()) rows.append(urwid.Divider())
m = revision.getPendingMessage() m = revision.getPendingMessage()
@ -155,7 +161,7 @@ class ReviewDialog(urwid.WidgetWrap):
for category, group in self.button_groups.items(): for category, group in self.button_groups.items():
for button in group: for button in group:
if button.state: if button.state:
approvals[category] = int(button.get_label()) approvals[category] = button._value
message = self.message.edit_text.strip() message = self.message.edit_text.strip()
self.change_view.saveReview(self.revision_row.revision_key, approvals, self.change_view.saveReview(self.revision_row.revision_key, approvals,
message, upload, submit) message, upload, submit)